1
0
mirror of https://github.com/flarum/core.git synced 2025-10-11 23:14:29 +02:00

Perform visibility checks on notification subjects at the query level

This will prevent a notification from being seen by a user if its
subject is deleted or undergoes some kind of permission change (eg.
a discussion is moved into a private tag)

ref #1380
This commit is contained in:
Toby Zerner
2018-11-11 16:58:08 +10:30
parent 17fdc0ebe0
commit 6d14d0c39b
4 changed files with 36 additions and 4 deletions

View File

@@ -100,10 +100,6 @@ class ListNotificationsController extends AbstractListController
$areMoreResults ? null : 0
);
$notifications = array_filter($notifications, function ($notification) {
return ! $notification->subjectModel || $notification->subject;
});
if (in_array('subject.discussion', $include)) {
$this->loadSubjectDiscussions($notifications);
}