From 6db544abb19e582bb8bf6db4e2b157e9ccd3cf41 Mon Sep 17 00:00:00 2001 From: Toby Zerner Date: Mon, 31 Aug 2015 13:54:28 +0930 Subject: [PATCH] Prevent error when saving tag without isHidden attribute closes flarum/core#289 --- extensions/tags/js/admin/src/components/EditTagModal.js | 2 +- extensions/tags/src/Tag.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/tags/js/admin/src/components/EditTagModal.js b/extensions/tags/js/admin/src/components/EditTagModal.js index 81d48cade..a9f56a21f 100644 --- a/extensions/tags/js/admin/src/components/EditTagModal.js +++ b/extensions/tags/js/admin/src/components/EditTagModal.js @@ -19,7 +19,7 @@ export default class EditTagModal extends Modal { this.slug = m.prop(this.tag.slug() || ''); this.description = m.prop(this.tag.description() || ''); this.color = m.prop(this.tag.color() || ''); - this.isHidden = m.prop(this.tag.isHidden() || ''); + this.isHidden = m.prop(this.tag.isHidden() || false); } className() { diff --git a/extensions/tags/src/Tag.php b/extensions/tags/src/Tag.php index 29f45071c..447ee0493 100644 --- a/extensions/tags/src/Tag.php +++ b/extensions/tags/src/Tag.php @@ -56,7 +56,7 @@ class Tag extends Model $tag->slug = $slug; $tag->description = $description; $tag->color = $color; - $tag->is_hidden = $isHidden; + $tag->is_hidden = (bool) $isHidden; return $tag; }