From 6ee9412f354f4fab20acd9ddb3f9d40b15334370 Mon Sep 17 00:00:00 2001 From: Toby Zerner Date: Fri, 4 Sep 2015 22:33:26 +0930 Subject: [PATCH] Prevent invalid LESS from crashing application Failure is silent for now... The default LESS will compile without the invalid customisations. Not sure if we should log an error somewhere and display it on the admin page? closes #400 --- src/Assets/LessCompiler.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/Assets/LessCompiler.php b/src/Assets/LessCompiler.php index c0c6ffd06..4093fe847 100644 --- a/src/Assets/LessCompiler.php +++ b/src/Assets/LessCompiler.php @@ -11,6 +11,7 @@ namespace Flarum\Assets; use Less_Parser; +use Less_Exception_Parser; class LessCompiler extends RevisionCompiler { @@ -28,7 +29,11 @@ class LessCompiler extends RevisionCompiler } foreach ($this->strings as $callback) { - $parser->parse($callback()); + try { + $parser->parse($callback()); + } catch (Less_Exception_Parser $e) { + // TODO: log an error somewhere? + } } return $parser->getCss();