From 705ef7536b80bc72ddfce340c5840a4f687c389d Mon Sep 17 00:00:00 2001 From: Toby Zerner Date: Tue, 19 Sep 2017 19:10:07 +0930 Subject: [PATCH] Don't include post content in the "basic" serializer Currently all of a post's replies are loaded in full whenever the post is loaded, which is kind of overkill - we really just need to know that they exist (and who posted them) in order to render the "X replied to this" line. --- .../core/src/Api/Serializer/DiscussionBasicSerializer.php | 6 +++--- framework/core/src/Api/Serializer/PostBasicSerializer.php | 6 ------ 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/framework/core/src/Api/Serializer/DiscussionBasicSerializer.php b/framework/core/src/Api/Serializer/DiscussionBasicSerializer.php index 39bee72ff..99416b10e 100644 --- a/framework/core/src/Api/Serializer/DiscussionBasicSerializer.php +++ b/framework/core/src/Api/Serializer/DiscussionBasicSerializer.php @@ -54,7 +54,7 @@ class DiscussionBasicSerializer extends AbstractSerializer */ protected function startPost($discussion) { - return $this->hasOne($discussion, 'Flarum\Api\Serializer\PostBasicSerializer'); + return $this->hasOne($discussion, 'Flarum\Api\Serializer\PostSerializer'); } /** @@ -70,7 +70,7 @@ class DiscussionBasicSerializer extends AbstractSerializer */ protected function lastPost($discussion) { - return $this->hasOne($discussion, 'Flarum\Api\Serializer\PostBasicSerializer'); + return $this->hasOne($discussion, 'Flarum\Api\Serializer\PostSerializer'); } /** @@ -86,6 +86,6 @@ class DiscussionBasicSerializer extends AbstractSerializer */ protected function relevantPosts($discussion) { - return $this->hasMany($discussion, 'Flarum\Api\Serializer\PostBasicSerializer'); + return $this->hasMany($discussion, 'Flarum\Api\Serializer\PostSerializer'); } } diff --git a/framework/core/src/Api/Serializer/PostBasicSerializer.php b/framework/core/src/Api/Serializer/PostBasicSerializer.php index 962a7b28b..c5ef11168 100644 --- a/framework/core/src/Api/Serializer/PostBasicSerializer.php +++ b/framework/core/src/Api/Serializer/PostBasicSerializer.php @@ -43,12 +43,6 @@ class PostBasicSerializer extends AbstractSerializer 'contentType' => $post->type ]; - if ($post instanceof CommentPost) { - $attributes['contentHtml'] = $post->content_html; - } else { - $attributes['content'] = $post->content; - } - return $attributes; }