From 731da100884a17feeee2cca2cd78eab5a0879ec8 Mon Sep 17 00:00:00 2001 From: Franz Liedke Date: Fri, 30 Nov 2018 14:04:44 +0100 Subject: [PATCH] Migrations: Fix dropping foreign keys Passing an array to dropForeign does not mean dropping multiple indices, but rather dropping a key on multiple tables. Passing a string means that this string will be interpreted as index name, not as name of the indexed column. Passing an array with one string is therefore correct, in order to benefit from automatic index name generation. --- ...06_27_102300_change_post_mentions_post_add_foreign_keys.php | 3 ++- ...06_27_102500_change_post_mentions_user_add_foreign_keys.php | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/extensions/mentions/migrations/2018_06_27_102300_change_post_mentions_post_add_foreign_keys.php b/extensions/mentions/migrations/2018_06_27_102300_change_post_mentions_post_add_foreign_keys.php index 09d729079..8018523a2 100644 --- a/extensions/mentions/migrations/2018_06_27_102300_change_post_mentions_post_add_foreign_keys.php +++ b/extensions/mentions/migrations/2018_06_27_102300_change_post_mentions_post_add_foreign_keys.php @@ -37,7 +37,8 @@ return [ 'down' => function (Builder $schema) { $schema->table('posts_mentions_posts', function (Blueprint $table) use ($schema) { - $table->dropForeign(['post_id', 'mentions_post_id']); + $table->dropForeign(['post_id']); + $table->dropForeign(['mentions_post_id']); Migration::fixIndexNames($schema, $table); }); diff --git a/extensions/mentions/migrations/2018_06_27_102500_change_post_mentions_user_add_foreign_keys.php b/extensions/mentions/migrations/2018_06_27_102500_change_post_mentions_user_add_foreign_keys.php index 0f0491867..339fae43f 100644 --- a/extensions/mentions/migrations/2018_06_27_102500_change_post_mentions_user_add_foreign_keys.php +++ b/extensions/mentions/migrations/2018_06_27_102500_change_post_mentions_user_add_foreign_keys.php @@ -37,7 +37,8 @@ return [ 'down' => function (Builder $schema) { $schema->table('post_mentions_user', function (Blueprint $table) use ($schema) { - $table->dropForeign(['post_id', 'mentions_user_id']); + $table->dropForeign(['post_id']); + $table->dropForeign(['mentions_user_id']); Migration::fixIndexNames($schema, $table); });