From 73da82ebc0b83e1ed7fd63f4ca29792bfdfe4cf6 Mon Sep 17 00:00:00 2001
From: Toby Zerner <toby.zerner@gmail.com>
Date: Sat, 21 Jul 2018 21:28:44 +0930
Subject: [PATCH] Don't save in the model

---
 framework/core/src/User/User.php                |  2 --
 framework/core/src/User/UserMetadataUpdater.php | 12 ++++++++++--
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/framework/core/src/User/User.php b/framework/core/src/User/User.php
index 39158fe4c..a7567b35e 100644
--- a/framework/core/src/User/User.php
+++ b/framework/core/src/User/User.php
@@ -766,7 +766,6 @@ class User extends AbstractModel
     public function refreshCommentsCount()
     {
         $this->comments_count = $this->posts()->count();
-        $this->save();
 
         return $this;
     }
@@ -779,7 +778,6 @@ class User extends AbstractModel
     public function refreshDiscussionsCount()
     {
         $this->discussions_count = $this->discussions()->count();
-        $this->save();
 
         return $this;
     }
diff --git a/framework/core/src/User/UserMetadataUpdater.php b/framework/core/src/User/UserMetadataUpdater.php
index 0814f4939..1297ea6bf 100644
--- a/framework/core/src/User/UserMetadataUpdater.php
+++ b/framework/core/src/User/UserMetadataUpdater.php
@@ -66,11 +66,19 @@ class UserMetadataUpdater
 
     private function updateCommentsCount(Post $post)
     {
-        optional($post->user)->refreshCommentsCount();
+        $user = $post->user;
+
+        if ($user && $user->exists) {
+            $user->refreshCommentsCount()->save();
+        }
     }
 
     private function updateDiscussionsCount(Discussion $discussion)
     {
-        optional($discussion->startUser)->refreshDiscussionsCount();
+        $user = $discussion->startUser;
+
+        if ($user && $user->exists) {
+            $user->refreshDiscussionsCount()->save();
+        }
     }
 }