From 75f237b674c5fa9656cb74e525ca86081ad9545c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dani=C3=ABl=20Klabbers?= <luceos@users.noreply.github.com>
Date: Tue, 29 May 2018 05:51:22 +0200
Subject: [PATCH] [wip] 1211 mariadb compatibility (#1440)

fixes #1211

As we've already upgraded our minimum requirement to 7.1 there's no current need to force a constraint on dbal 2.7+.
---
 framework/core/.travis.yml                    | 25 ++++++++++++++-----
 framework/core/phpunit.xml                    |  5 ++++
 .../core/tests/Test/Concerns/CreatesForum.php |  7 +++---
 3 files changed, 28 insertions(+), 9 deletions(-)

diff --git a/framework/core/.travis.yml b/framework/core/.travis.yml
index 58beeeeac..8bfa212b6 100644
--- a/framework/core/.travis.yml
+++ b/framework/core/.travis.yml
@@ -1,9 +1,12 @@
 language: php
+sudo: false
 
 env:
-  - DB_USERNAME=travis
-services:
-  - mysql
+  global:
+    - DB=mariadb
+
+addons:
+  mariadb: '10.2'
 
 php:
   - 7.1
@@ -11,8 +14,20 @@ php:
 
 matrix:
   fast_finish: true
+  include:
+    - php: 7.1
+      addons: # to prevent mariadb
+      services: mysql
+      env:
+        - DB=mysql
+    - php: 7.2
+      addons: # to prevent mariadb
+      services: mysql
+      env:
+        - DB=mysql
+
 before_install:
-  - mysql -e 'CREATE DATABASE flarum;'
+  - if [[ "$DB" == "mysql" || "$DB" == "mariadb" ]]; then mysql -e 'CREATE DATABASE flarum;'; fi
 before_script:
   - composer self-update
   - composer install
@@ -26,5 +41,3 @@ notifications:
 
 after_success:
   - bash <(curl -s https://codecov.io/bash)
-
-sudo: false
diff --git a/framework/core/phpunit.xml b/framework/core/phpunit.xml
index 6bdd4b7c7..9a6492957 100644
--- a/framework/core/phpunit.xml
+++ b/framework/core/phpunit.xml
@@ -19,4 +19,9 @@
             <exclude>./tests/Install</exclude>
         </testsuite>
     </testsuites>
+    <filter>
+        <whitelist processUncoveredFilesFromWhitelist="true">
+            <directory suffix=".php">./src/</directory>
+        </whitelist>
+    </filter>
 </phpunit>
diff --git a/framework/core/tests/Test/Concerns/CreatesForum.php b/framework/core/tests/Test/Concerns/CreatesForum.php
index 6be88436d..ac4029731 100644
--- a/framework/core/tests/Test/Concerns/CreatesForum.php
+++ b/framework/core/tests/Test/Concerns/CreatesForum.php
@@ -75,9 +75,10 @@ trait CreatesForum
         $data->setSetting('mail_driver', 'log');
 
         $database = $data->getDatabaseConfiguration();
-        $database['database'] = env('DB_DATABASE', 'flarum');
-        $database['username'] = env('DB_USERNAME', 'root');
-        $database['password'] = env('DB_PASSWORD', '');
+        $database['host'] = env('DB_HOST', $database['host']);
+        $database['database'] = env('DB_DATABASE', $database['database']);
+        $database['username'] = env('DB_USERNAME', $database['username']);
+        $database['password'] = env('DB_PASSWORD', $database['password']);
         $data->setDatabaseConfiguration($database);
 
         $this->configuration = $data;