From 7667b80bf7d2b6267b680f8df51a1b83586e46c5 Mon Sep 17 00:00:00 2001
From: Franz Liedke <franz@develophp.org>
Date: Thu, 8 Feb 2018 17:14:28 +0100
Subject: [PATCH] Flatten logic

With an early return, the method becomes more readable, and the
actual (very small) change from #46 becomes more apparent.
---
 .../tags/src/Listener/UpdateTagMetadata.php   | 23 +++++++++++--------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/extensions/tags/src/Listener/UpdateTagMetadata.php b/extensions/tags/src/Listener/UpdateTagMetadata.php
index 14dffebaf..e428fb572 100755
--- a/extensions/tags/src/Listener/UpdateTagMetadata.php
+++ b/extensions/tags/src/Listener/UpdateTagMetadata.php
@@ -110,22 +110,25 @@ class UpdateTagMetadata
             return;
         }
 
+        // We do not count private discussions in tags
+        if ($discussion->is_private) {
+            return;
+        }
+
         if (! $tags) {
             $tags = $discussion->tags;
         }
 
-        if (! $discussion->is_private) {
-            foreach ($tags as $tag) {
-                $tag->discussions_count += $delta;
+        foreach ($tags as $tag) {
+            $tag->discussions_count += $delta;
 
-                if ($discussion->last_time > $tag->last_time) {
-                    $tag->setLastDiscussion($discussion);
-                } elseif ($discussion->id == $tag->last_discussion_id) {
-                    $tag->refreshLastDiscussion();
-                }
-
-                $tag->save();
+            if ($discussion->last_time > $tag->last_time) {
+                $tag->setLastDiscussion($discussion);
+            } elseif ($discussion->id == $tag->last_discussion_id) {
+                $tag->refreshLastDiscussion();
             }
+
+            $tag->save();
         }
     }
 }