From 79c1fdf5db9a643cebd476374e3d67860036a38d Mon Sep 17 00:00:00 2001 From: Franz Liedke Date: Thu, 10 Dec 2015 11:35:51 +0100 Subject: [PATCH] Don't return from inside a finally block This is not supported in HHVM: https://github.com/facebook/hhvm/issues/5162 Reported on the forum: https://discuss.flarum.org/d/1390-migrating-from-php-5-6-x-to-php-7-0-x/7 --- framework/core/src/Foundation/Application.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/framework/core/src/Foundation/Application.php b/framework/core/src/Foundation/Application.php index 7b18af206..78c778ee3 100644 --- a/framework/core/src/Foundation/Application.php +++ b/framework/core/src/Foundation/Application.php @@ -117,8 +117,10 @@ class Application extends Container implements ApplicationContract try { $version = $settings->get('version'); } finally { - return isset($version) && $version === $this->version(); + $isUpToDate = isset($version) && $version === $this->version(); } + + return $isUpToDate; } /**