mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-20 16:21:18 +02:00
Code Issues Releases Wiki Activity

Use early returns to flatten methods

Browse Source
This commit is contained in:
Franz Liedke
2018-09-26 22:59:48 +02:00
parent 5704c37c18
commit 7e8279ec04
1 changed files with 34 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
framework/core/src/Extension/ExtensionManager.php
View File

@@ -113,7 +113,10 @@ class ExtensionManager
*/ */
public function enable($name) public function enable($name)
{ {
if (! $this->isEnabled($name)) { if ($this->isEnabled($name)) {
return;
}
$extension = $this->getExtension($name); $extension = $this->getExtension($name);
$this->dispatcher->dispatch(new Enabling($extension)); $this->dispatcher->dispatch(new Enabling($extension));
@@ -132,7 +135,6 @@ class ExtensionManager
$this->dispatcher->dispatch(new Enabled($extension)); $this->dispatcher->dispatch(new Enabled($extension));
} }
}
/** /**
* Disables an extension. * Disables an extension.
@@ -143,7 +145,10 @@ class ExtensionManager
{ {
$enabled = $this->getEnabled(); $enabled = $this->getEnabled();
if (($k = array_search($name, $enabled)) !== false) { if (($k = array_search($name, $enabled)) === false) {
return;
}
$extension = $this->getExtension($name); $extension = $this->getExtension($name);
$this->dispatcher->dispatch(new Disabling($extension)); $this->dispatcher->dispatch(new Disabling($extension));
@@ -156,7 +161,6 @@ class ExtensionManager
$this->dispatcher->dispatch(new Disabled($extension)); $this->dispatcher->dispatch(new Disabled($extension));
} }
}
/** /**
* Uninstalls an extension. * Uninstalls an extension.