mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-28 20:20:34 +02:00
Code Issues Releases Wiki Activity

Use early returns to flatten methods

Browse Source
This commit is contained in:
Franz Liedke
2018-09-26 22:59:48 +02:00
parent 5704c37c18
commit 7e8279ec04
1 changed files with 34 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
framework/core/src/Extension/ExtensionManager.php
View File

@@ -113,25 +113,27 @@ class ExtensionManager
*/ */
public function enable($name) public function enable($name)
{ {
if (! $this->isEnabled($name)) { if ($this->isEnabled($name)) {
$extension = $this->getExtension($name); return;
$this->dispatcher->dispatch(new Enabling($extension));
$enabled = $this->getEnabled();
$enabled[] = $name;
$this->migrate($extension);
$this->publishAssets($extension);
$this->setEnabled($enabled);
$extension->enable($this->app);
$this->dispatcher->dispatch(new Enabled($extension));
} }
$extension = $this->getExtension($name);
$this->dispatcher->dispatch(new Enabling($extension));
$enabled = $this->getEnabled();
$enabled[] = $name;
$this->migrate($extension);
$this->publishAssets($extension);
$this->setEnabled($enabled);
$extension->enable($this->app);
$this->dispatcher->dispatch(new Enabled($extension));
} }
/** /**
@@ -143,19 +145,21 @@ class ExtensionManager
{ {
$enabled = $this->getEnabled(); $enabled = $this->getEnabled();
if (($k = array_search($name, $enabled)) !== false) { if (($k = array_search($name, $enabled)) === false) {
$extension = $this->getExtension($name); return;
$this->dispatcher->dispatch(new Disabling($extension));
unset($enabled[$k]);
$this->setEnabled($enabled);
$extension->disable($this->app);
$this->dispatcher->dispatch(new Disabled($extension));
} }
$extension = $this->getExtension($name);
$this->dispatcher->dispatch(new Disabling($extension));
unset($enabled[$k]);
$this->setEnabled($enabled);
$extension->disable($this->app);
$this->dispatcher->dispatch(new Disabled($extension));
} }
/** /**