From 7feab89cca25fb0426d986f25dff0ef7bd8c7d33 Mon Sep 17 00:00:00 2001
From: Davide Iadeluca <146922689+DavideIadeluca@users.noreply.github.com>
Date: Fri, 21 Feb 2025 09:38:06 +0100
Subject: [PATCH] fix(a11y): change starting position of `aria-posinset`
 (#4191)

---
 framework/core/js/src/forum/components/DiscussionList.js | 2 +-
 framework/core/js/src/forum/components/PostList.tsx      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/framework/core/js/src/forum/components/DiscussionList.js b/framework/core/js/src/forum/components/DiscussionList.js
index 1582eb4ca..8b5f9bdfa 100644
--- a/framework/core/js/src/forum/components/DiscussionList.js
+++ b/framework/core/js/src/forum/components/DiscussionList.js
@@ -51,7 +51,7 @@ export default class DiscussionList extends Component {
         <ul role="feed" aria-busy={isLoading} className="DiscussionList-discussions">
           {state.getPages().map((pg, pageNum) => {
             return pg.items.map((discussion, itemNum) => (
-              <li key={discussion.id()} data-id={discussion.id()} role="article" aria-setsize="-1" aria-posinset={pageNum * pageSize + itemNum}>
+              <li key={discussion.id()} data-id={discussion.id()} role="article" aria-setsize="-1" aria-posinset={pageNum * pageSize + itemNum + 1}>
                 <DiscussionListItem discussion={discussion} params={params} />
               </li>
             ));
diff --git a/framework/core/js/src/forum/components/PostList.tsx b/framework/core/js/src/forum/components/PostList.tsx
index 01287b2f6..f7ed56de4 100644
--- a/framework/core/js/src/forum/components/PostList.tsx
+++ b/framework/core/js/src/forum/components/PostList.tsx
@@ -45,7 +45,7 @@ export default class PostList<CustomAttrs extends IPostListAttrs = IPostListAttr
         <ul role="feed" aria-busy={isLoading} className="PostList-discussions">
           {state.getPages().map((pg, pageNum) => {
             return pg.items.map((post, itemNum) => (
-              <li key={post.id()} data-id={post.id()} role="article" aria-setsize="-1" aria-posinset={pageNum * pageSize + itemNum}>
+              <li key={post.id()} data-id={post.id()} role="article" aria-setsize="-1" aria-posinset={pageNum * pageSize + itemNum + 1}>
                 <PostListItem post={post} params={params} />
               </li>
             ));