mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-30 13:10:24 +02:00
Code Issues Releases Wiki Activity

Add logic to make sure post mention preview isn't hidden by header. closes flarum/core#316

Browse Source
This commit is contained in:
Toby Zerner
2016-03-28 13:33:46 +10:30
parent 2ddfb11614
commit 865238df81
2 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
extensions/mentions/js/forum/dist/extension.js vendored
View File

@@ -531,7 +531,18 @@ System.register('flarum/mentions/addPostMentionPreviews', ['flarum/extend', 'fla
// Position the preview so that it appears above the mention. // Position the preview so that it appears above the mention.
// (The offsetParent should be .Post-body.) // (The offsetParent should be .Post-body.)
var positionPreview = function positionPreview() { var positionPreview = function positionPreview() {
$preview.show().css('top', $this.offset().top - $parentPost.offset().top - $preview.outerHeight(true)).css('left', $this.offsetParent().offset().left - $parentPost.offset().left).css('max-width', $this.offsetParent().width()); var previewHeight = $preview.outerHeight(true);
var offset = 0;
// If the preview goes off the top of the viewport, reposition it to
// be below the mention.
if ($this.offset().top - previewHeight < $(window).scrollTop() + $('#header').outerHeight()) {
offset += $this.outerHeight(true);
} else {
offset -= previewHeight;
}
$preview.show().css('top', $this.offset().top - $parentPost.offset().top + offset).css('left', $this.offsetParent().offset().left - $parentPost.offset().left).css('max-width', $this.offsetParent().width());
}; };
var showPost = function showPost(post) { var showPost = function showPost(post) {

13
extensions/mentions/js/forum/src/addPostMentionPreviews.js
View File

@@ -53,8 +53,19 @@ export default function addPostMentionPreviews() {
// Position the preview so that it appears above the mention. // Position the preview so that it appears above the mention.
// (The offsetParent should be .Post-body.) // (The offsetParent should be .Post-body.)
const positionPreview = () => { const positionPreview = () => {
const previewHeight = $preview.outerHeight(true);
let offset = 0;
// If the preview goes off the top of the viewport, reposition it to
// be below the mention.
if ($this.offset().top - previewHeight < $(window).scrollTop() + $('#header').outerHeight()) {
offset += $this.outerHeight(true);
} else {
offset -= previewHeight;
}
$preview.show() $preview.show()
.css('top', $this.offset().top - $parentPost.offset().top - $preview.outerHeight(true)) .css('top', $this.offset().top - $parentPost.offset().top + offset)
.css('left', $this.offsetParent().offset().left - $parentPost.offset().left) .css('left', $this.offsetParent().offset().left - $parentPost.offset().left)
.css('max-width', $this.offsetParent().width()); .css('max-width', $this.offsetParent().width());
}; };