chore: avoid using .fa() mixins and @fa-var vars (#3912)

framework/core/js/src/forum/components/Composer.js

@@ -338,7 +338,10 @@ export default class Composer extends Component {
         items.add(
           'minimize',
           <ComposerButton
-            icon="fas fa-minus minimize"
+            icon={classList('fas minimize', {
+              'fa-minus': app.screen() !== 'phone',
+              'fa-times': app.screen() === 'phone',
+            })}
             title={app.translator.trans('core.forum.composer.minimize_tooltip')}
             onclick={this.state.minimize.bind(this.state)}
             itemClassName="App-backControl"

framework/core/js/src/forum/components/Search.tsx

@@ -145,6 +145,7 @@ export default class Search<T extends SearchAttrs = SearchAttrs> extends Compone
         })}
       >
         <div className="Search-input">
+          <Icon name="fas fa-search Search-input-icon" />
           <input
             aria-label={searchLabel}
             className="FormControl"

framework/core/less/common/Search.less

@@ -58,9 +58,7 @@
   overflow: hidden;
   color: var(--muted-color);
 
-  &:before {
-    .fas();
-    content: @fa-var-search;
+  &-icon {
     margin-right: -36px;
     width: 36px;
     font-size: 14px;

framework/core/less/common/Select.less

@@ -16,5 +16,6 @@
   margin-left: -30px;
   pointer-events: none;
   color: var(--control-color);
-  .fa-fw();
+  text-align: center;
+  width: 1.25em;
 }

framework/core/less/common/Table.less

@@ -41,7 +41,8 @@
     .icon {
       font-size: 14px;
       margin-right: 2px;
-      .fa-fw();
+      text-align: center;
+      width: 1.25em;
     }
   }
 

framework/core/less/forum/Composer.less

@@ -155,9 +155,6 @@
       }
     }
   }
-  .Composer-controls .fa-minus:before {
-    content: @fa-var-times;
-  }
   .composer-backdrop {
     position: fixed;
     top: 0;