mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-06 08:27:42 +02:00
Code Issues Releases Wiki Activity

Fix some review issues

Browse Source
This commit is contained in:
Matthew Kilgore
2020-11-26 20:45:09 -05:00
parent 1eb316bf44
commit 92a5b98b77
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
js/src/common/components/Select.js
View File

@@ -13,7 +13,7 @@ import withAttr from '../utils/withAttr';
*/ */
export default class Select extends Component { export default class Select extends Component {
view() { view() {
const { options, onchange, value, disabled, bidi } = this.attrs; const { options, onchange, value, disabled } = this.attrs;
return ( return (
<span className="Select"> <span className="Select">

4
src/Discussion/IdWithSlugDriver.php → src/Discussion/IdWithTransliteratedSlugDriver.php
View File

@@ -13,7 +13,7 @@ use Flarum\Database\AbstractModel;
use Flarum\Http\SlugDriverInterface; use Flarum\Http\SlugDriverInterface;
use Flarum\User\User; use Flarum\User\User;
class IdWithSlugDriver implements SlugDriverInterface class IdWithTransliteratedSlugDriver implements SlugDriverInterface
{ {
public function toSlug(AbstractModel $instance): string public function toSlug(AbstractModel $instance): string
{ {
@@ -22,7 +22,7 @@ class IdWithSlugDriver implements SlugDriverInterface
public function fromSlug(string $slug, User $actor): AbstractModel public function fromSlug(string $slug, User $actor): AbstractModel
{ {
if (strpos($slug, '-') == true) { if (strpos($slug, '-')) {
$slug_array = explode('-', $slug); $slug_array = explode('-', $slug);
$slug = $slug_array[0]; $slug = $slug_array[0];
} }

4
src/Http/HttpServiceProvider.php
View File

@@ -10,7 +10,7 @@
namespace Flarum\Http; namespace Flarum\Http;
use Flarum\Discussion\Discussion; use Flarum\Discussion\Discussion;
use Flarum\Discussion\IdWithSlugDriver; use Flarum\Discussion\IdWithTransliteratedSlugDriver;
use Flarum\Foundation\AbstractServiceProvider; use Flarum\Foundation\AbstractServiceProvider;
use Flarum\Foundation\Application; use Flarum\Foundation\Application;
use Flarum\Post\Post; use Flarum\Post\Post;
@@ -36,7 +36,7 @@ class HttpServiceProvider extends AbstractServiceProvider
$this->app->singleton('flarum.http.slugDrivers', function () { $this->app->singleton('flarum.http.slugDrivers', function () {
return [ return [
Discussion::class => [ Discussion::class => [
'default' => IdWithSlugDriver::class 'default' => IdWithTransliteratedSlugDriver::class
], ],
User::class => [ User::class => [
'default' => UsernameSlugDriver::class 'default' => UsernameSlugDriver::class