mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-05 16:07:34 +02:00
Code Issues Releases Wiki Activity

fix: resolve a11y warnings in Admin Frontend (#4184)

Browse Source
This commit is contained in:
Davide Iadeluca
2025-02-11 20:24:44 +01:00
committed by GitHub
parent 79e969778e
commit a34a5d4d62
5 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
framework/core/js/src/admin/components/PermissionGrid.tsx
View File

@@ -59,7 +59,12 @@ export default class PermissionGrid<CustomAttrs extends IPermissionGridAttrs = I
<th>
{scope.label}{' '}
{!!scope.onremove && (
<Button icon="fas fa-times" className="Button Button--text PermissionGrid-removeScope" onclick={scope.onremove} />
<Button
icon="fas fa-times"
className="Button Button--text PermissionGrid-removeScope"
aria-label={app.translator.trans('core.admin.permissions.remove_scope_label', { scope: scope.label })}
onclick={scope.onremove}
/>
)}
</th>
))}

4
framework/core/js/src/common/components/Pagination.tsx
View File

@@ -23,6 +23,7 @@ export default class Pagination<CustomAttrs extends IPaginationInterface = IPagi
<Button
disabled={currentPage === 1}
title={app.translator.trans('core.lib.pagination.first_button')}
aria-label={app.translator.trans('core.lib.pagination.first_button')}
onclick={() => onChange(1)}
icon="fas fa-step-backward"
className="Button Button--icon Pagination-first"
@@ -30,6 +31,7 @@ export default class Pagination<CustomAttrs extends IPaginationInterface = IPagi
<Button
disabled={currentPage === 1}
title={app.translator.trans('core.lib.pagination.back_button')}
aria-label={app.translator.trans('core.lib.pagination.back_button')}
onclick={() => onChange(currentPage - 1)}
icon="fas fa-chevron-left"
className="Button Button--icon Pagination-back"
@@ -77,6 +79,7 @@ export default class Pagination<CustomAttrs extends IPaginationInterface = IPagi
<Button
disabled={!moreData}
title={app.translator.trans('core.lib.pagination.next_button')}
aria-label={app.translator.trans('core.lib.pagination.next_button')}
onclick={() => onChange(currentPage + 1)}
icon="fas fa-chevron-right"
className="Button Button--icon Pagination-next"
@@ -84,6 +87,7 @@ export default class Pagination<CustomAttrs extends IPaginationInterface = IPagi
<Button
disabled={!moreData}
title={app.translator.trans('core.lib.pagination.last_button')}
aria-label={app.translator.trans('core.lib.pagination.last_button')}
onclick={() => onChange(totalPageCount)}
icon="fas fa-step-forward"
className="Button Button--icon Pagination-last"

1
framework/core/locale/core.yml
View File

@@ -310,6 +310,7 @@ core:
participate_heading: Participate
post_without_throttle_label: Reply multiple times without waiting
read_heading: Read
remove_scope_label: Remove scope of {scope}
rename_discussions_label: Rename discussions
reply_to_discussions_label: Reply to discussions
search_users_label: => core.ref.search_users