fix: Assorted Typing Fixes (#3348)

With all the commits below, we resolve all outstanding typing issues in the repo, and CI jobs run green. * fix: Convert DashboardPage and DashboardWidget to TypeScript * fix: fix type errors in package manager ext * fix: Convert Post component to TypeScript * fix: avatar typings should accept null user * fix: convert Notification component to TypeScript * fix: properly use `typeof` in ForumApplication * feat: make Notification content attr generic * chore: format Notification component * fix: Convert DiscussionRenamedNotification to TypeScript * fix(pusher) move shims to a location where they get applied * fix(pusher): fix some typing errors * fix(akismet): fix some typing issues * chore: update core dist typings * chore(pusher): format * fix: anchorScroll should accept string selectors * fix: more accurately represent ApiQueryParamsPlural * fix: convert PostStreamState to TypeScript * chore(core): rebuild typings * feat: allow extending app.routes * fix: more flexible typings for highlight.ts * fix: use primitive `number` type for Discussion typings * fix: convert DiscussionListItem to TypeScript * chore: rebuild core typings * fix: final pusher type fixes * feat: start tags TypeScript conversion * fix: require-dev tags in pusher for CI TypeScript purposes. * chore(core): format * chore(tags): build dist typings * feat(pusher): use dist types from tags. * feat: convert flags to TypeScript * chore(flags): generate dist typings * fix(akismet): last type errors * chore: update .yarn-integrity * chore: partially run flarum-cli audit infra --fix The tsconfig changes from that command are ignored, since we don't yet support "replacable sections" that would let us add custom config. * chore: use type imports * fix: broader gitattributes * chore: run flarum-cli audit infra --monorepo --fix * feat: make `app.data` typings extensible * chore(core): format * chore: boost tags TypeScript coverage * fix(tags): further increase type coverage.
2025-08-08 09:26:34 +02:00 · 2022-03-23 11:43:14 -04:00
parent 4ecd9a9b2f
commit a595665bfb
255 changed files with 1578 additions and 1218 deletions
--- a/.github/workflows/flarum-akismet-frontend.yml
+++ b/.github/workflows/flarum-akismet-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/akismet
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-approval-frontend.yml
+++ b/.github/workflows/flarum-approval-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/approval
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-core-frontend.yml
+++ b/.github/workflows/flarum-core-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./framework/core
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-embed-frontend.yml
+++ b/.github/workflows/flarum-embed-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/embed
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-emoji-frontend.yml
+++ b/.github/workflows/flarum-emoji-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/emoji
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-flags-frontend.yml
+++ b/.github/workflows/flarum-flags-frontend.yml
@@ -12,11 +12,12 @@ jobs:
    with:
      enable_bundlewatch: false
      enable_prettier: true
-      enable_typescript: false
+      enable_typescript: true

      frontend_directory: ./extensions/flags/js
      backend_directory: ./extensions/flags
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-likes-frontend.yml
+++ b/.github/workflows/flarum-likes-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/likes
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-lock-frontend.yml
+++ b/.github/workflows/flarum-lock-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/lock
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-markdown-frontend.yml
+++ b/.github/workflows/flarum-markdown-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/markdown
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-mentions-frontend.yml
+++ b/.github/workflows/flarum-mentions-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/mentions
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-nicknames-frontend.yml
+++ b/.github/workflows/flarum-nicknames-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/nicknames
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-package-manager-frontend.yml
+++ b/.github/workflows/flarum-package-manager-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/package-manager
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-pusher-frontend.yml
+++ b/.github/workflows/flarum-pusher-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/pusher
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-statistics-frontend.yml
+++ b/.github/workflows/flarum-statistics-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/statistics
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-sticky-frontend.yml
+++ b/.github/workflows/flarum-sticky-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/sticky
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-subscriptions-frontend.yml
+++ b/.github/workflows/flarum-subscriptions-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/subscriptions
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-suspend-frontend.yml
+++ b/.github/workflows/flarum-suspend-frontend.yml
@@ -18,5 +18,6 @@ jobs:
      backend_directory: ./extensions/suspend
      js_package_manager: yarn
      main_git_branch: main
+
    secrets:
      bundlewatch_github_token: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
--- a/.github/workflows/flarum-tags-frontend.yml
+++ b/.github/workflows/flarum-tags-frontend.yml
@@ -12,7 +12,7 @@ jobs:
    with:
      enable_bundlewatch: false
      enable_prettier: false
-      enable_typescript: false
+      enable_typescript: true

      frontend_directory: ./extensions/tags/js
      backend_directory: ./extensions/tags