mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-06 00:17:31 +02:00
Code Issues Releases Wiki Activity

feat(seo): shift h1 tag from logo to discussion title (#3724)

Browse Source 
* feat(seo): shift h1 tag from logo to discussion title

Many times have we seen opponents of using h2 as the discussion title. Although
my own SEO knowledge is limited, I have seen the importance of structuring pages
according to the content you wish to prioritize. If we only take that into consideration
there is zero reason for the app-wide identical logo to take precedence over any
other heading.

This change makes the logo a standard (visually identical) element, and
makes the discussion hero title a h1.

* feat(seo): rewrite remainder of hero titles and subtitles
This commit is contained in:
Daniël Klabbers
2023-02-11 13:27:46 +01:00
committed by GitHub
parent 153bb1a53c
commit aa0b3288d5
13 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/package-manager/js/src/admin/components/ControlSection.tsx
View File

@@ -17,7 +17,7 @@ export default class ControlSection extends Component<ComponentAttrs> {
<div className="ExtensionPage-permissions PackageManager-controlSection">
<div className="ExtensionPage-permissions-header">
<div className="container">
<h2 className="ExtensionTitle">{app.translator.trans('flarum-package-manager.admin.sections.control.title')}</h2>
<h1 className="ExtensionTitle">{app.translator.trans('flarum-package-manager.admin.sections.control.title')}</h1>
</div>
</div>
<div className="container">

2
extensions/package-manager/js/src/admin/components/QueueSection.tsx
View File

@@ -32,7 +32,7 @@ export default class QueueSection extends Component<{}> {
<section id="PackageManager-queueSection" className="ExtensionPage-permissions PackageManager-queueSection">
<div className="ExtensionPage-permissions-header PackageManager-queueSection-header">
<div className="container">
<h2 className="ExtensionTitle">{app.translator.trans('flarum-package-manager.admin.sections.queue.title')}</h2>
<h1 className="ExtensionTitle">{app.translator.trans('flarum-package-manager.admin.sections.queue.title')}</h1>
<Button
className="Button Button--icon"
icon="fas fa-sync-alt"

4
extensions/tags/js/src/forum/components/TagHero.js
View File

@@ -15,9 +15,9 @@ export default class TagHero extends Component {
>
<div className="container">
<div className="containerNarrow">
<h2 className="Hero-title">
<h1 className="Hero-title">
{tag.icon() && tagIcon(tag, {}, { useColor: false })} {tag.name()}
</h2>
</h1>
<div className="Hero-subtitle">{tag.description()}</div>
</div>
</div>

2
extensions/tags/views/frontend/content/tag.blade.php
View File

@@ -1,7 +1,7 @@
@inject('url', 'Flarum\Http\UrlGenerator')
<div class="container">
<h2>{{ $tag->name }}</h2>
<h1>{{ $tag->name }}</h1>
<p>{{ $tag->description }}</p>
<ul>

2
extensions/tags/views/frontend/content/tags.blade.php
View File

@@ -1,7 +1,7 @@
@inject('url', 'Flarum\Http\UrlGenerator')
<div class="container">
<h2>{{ $translator->trans('flarum-tags.forum.index.tags_link') }}</h2>
<h1>{{ $translator->trans('flarum-tags.forum.index.tags_link') }}</h1>
@foreach ([$primaryTags, $secondaryTags] as $category)
<ul>