1
0
mirror of https://github.com/flarum/core.git synced 2025-08-05 07:57:46 +02:00

feat(seo): shift h1 tag from logo to discussion title (#3724)

* feat(seo): shift h1 tag from logo to discussion title

Many times have we seen opponents of using h2 as the discussion title. Although
my own SEO knowledge is limited, I have seen the importance of structuring pages
according to the content you wish to prioritize. If we only take that into consideration
there is zero reason for the app-wide identical logo to take precedence over any
other heading.

This change makes the logo a standard (visually identical) element, and
makes the discussion hero title a h1.

* feat(seo): rewrite remainder of hero titles and subtitles
This commit is contained in:
Daniël Klabbers
2023-02-11 13:27:46 +01:00
committed by GitHub
parent 153bb1a53c
commit aa0b3288d5
13 changed files with 20 additions and 20 deletions

View File

@@ -7,7 +7,7 @@
<header id="header" class="App-header">
<div id="header-navigation" class="Header-navigation"></div>
<div class="container">
<h1 class="Header-title">
<div class="Header-title">
<a href="{{ $forum['baseUrl'] }}">
@if ($forum['logoUrl'])
<img src="{{ $forum['logoUrl'] }}" alt="{{ $forum['title'] }}" class="Header-logo">
@@ -15,7 +15,7 @@
{{ $forum['title'] }}
@endif
</a>
</h1>
</div>
<div id="header-primary" class="Header-primary"></div>
<div id="header-secondary" class="Header-secondary"></div>
</div>

View File

@@ -9,7 +9,7 @@
<header id="header" class="App-header">
<div id="header-navigation" class="Header-navigation"></div>
<div class="container">
<h1 class="Header-title">
<div class="Header-title">
<a href="{{ $forum['baseUrl'] }}" id="home-link">
@if ($forum['logoUrl'])
<img src="{{ $forum['logoUrl'] }}" alt="{{ $forum['title'] }}" class="Header-logo">
@@ -17,7 +17,7 @@
{{ $forum['title'] }}
@endif
</a>
</h1>
</div>
<div id="header-primary" class="Header-primary"></div>
<div id="header-secondary" class="Header-secondary"></div>
</div>