From ae3d1f5f5f92705abc977e732a237d0f9b858ee8 Mon Sep 17 00:00:00 2001 From: Franz Liedke Date: Fri, 30 Nov 2018 14:04:12 +0100 Subject: [PATCH] Migrations: Fix dropping foreign keys Passing an array to dropForeign does not mean dropping multiple indices, but rather dropping a key on multiple tables. Passing a string means that this string will be interpreted as index name, not as name of the indexed column. Passing an array with one string is therefore correct, in order to benefit from automatic index name generation. --- .../2018_06_27_101600_change_flags_add_foreign_keys.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/extensions/flags/migrations/2018_06_27_101600_change_flags_add_foreign_keys.php b/extensions/flags/migrations/2018_06_27_101600_change_flags_add_foreign_keys.php index 9dcdf3ede..db3194c07 100644 --- a/extensions/flags/migrations/2018_06_27_101600_change_flags_add_foreign_keys.php +++ b/extensions/flags/migrations/2018_06_27_101600_change_flags_add_foreign_keys.php @@ -41,7 +41,8 @@ return [ 'down' => function (Builder $schema) { $schema->table('flags', function (Blueprint $table) use ($schema) { - $table->dropForeign(['post_id', 'user_id']); + $table->dropForeign(['post_id']); + $table->dropForeign(['user_id']); Migration::fixIndexNames($schema, $table); });