mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-09 18:07:02 +02:00
Code Issues Releases Wiki Activity

Enable conditional migrations through when callback

Browse Source
This commit is contained in:
Clark Winkelmann
2022-11-21 14:27:44 +01:00
parent e5d2b8cad9
commit b015a66456
1 changed files with 24 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
framework/core/src/Database/Migrator.php
View File

@@ -124,7 +124,22 @@ class Migrator
*/ */
protected function runUp($path, $file, Extension $extension = null) protected function runUp($path, $file, Extension $extension = null)
{ {
$this->resolveAndRunClosureMigration($path, $file); $migration = $this->resolve($path, $file);
// If a "when" callback in defined in a migration array, a falsy return value will cause the migration to skip
if (is_array($migration) && array_key_exists('when', $migration)) {
if (!call_user_func($migration['when'], $this->connection->getSchemaBuilder())) {
$this->note("<info>Skipped:</info> $file");
return;
}
}
try {
$this->runClosureMigration($migration);
} catch (MigrationKeyMissing $exception) {
throw $exception->withFile("$path/$file.php");
}
// Once we have run a migrations class, we will log that it was run in this // Once we have run a migrations class, we will log that it was run in this
// repository so that we don't try to run it next time we do a migration // repository so that we don't try to run it next time we do a migration
@@ -165,13 +180,18 @@ class Migrator
* *
* @param string $path * @param string $path
* @param string $file * @param string $file
* @param string $path * @param Extension|null $extension
* @param Extension $extension
* @return void * @return void
*/ */
protected function runDown($path, $file, Extension $extension = null) protected function runDown($path, $file, Extension $extension = null)
{ {
$this->resolveAndRunClosureMigration($path, $file, 'down'); $migration = $this->resolve($path, $file);
try {
$this->runClosureMigration($migration, 'down');
} catch (MigrationKeyMissing $exception) {
throw $exception->withFile("$path/$file.php");
}
// Once we have successfully run the migration "down" we will remove it from // Once we have successfully run the migration "down" we will remove it from
// the migration repository so it will be considered to have not been run // the migration repository so it will be considered to have not been run
@@ -197,25 +217,6 @@ class Migrator
} }
} }
/**
* Resolves and run a migration and assign the filename to the exception if needed.
*
* @param string $path
* @param string $file
* @param string $direction
* @throws MigrationKeyMissing
*/
protected function resolveAndRunClosureMigration(string $path, string $file, string $direction = 'up')
{
$migration = $this->resolve($path, $file);
try {
$this->runClosureMigration($migration, $direction);
} catch (MigrationKeyMissing $exception) {
throw $exception->withFile("$path/$file.php");
}
}
/** /**
* Get all of the migration files in a given path. * Get all of the migration files in a given path.
* *