mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-06 08:27:42 +02:00
Code Issues Releases Wiki Activity

Rename view extender

Browse Source 
As discussed in my initial review, it seems unlikely that we need
the ability to remove (or otherwise modify) namespaces again.
Therefore, it seems more consistent with other extenders to go
for a "View" extender with a "namespace" method.

Sorry for the back and forth. ;)

Refs #1891, #2134.
This commit is contained in:
Franz Liedke
2020-07-17 12:04:04 +02:00
parent 3b6dbddee9
commit b89ccaf83c
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
framework/core/tests/integration/extenders/ViewNamespaceTest.php → framework/core/tests/integration/extenders/ViewTest.php
View File

@@ -13,7 +13,7 @@ use Flarum\Extend;
use Flarum\Tests\integration\TestCase;
use Illuminate\Contracts\View\Factory;
class ViewNamespaceTest extends TestCase
class ViewTest extends TestCase
{
/**
* @test
@@ -30,8 +30,8 @@ class ViewNamespaceTest extends TestCase
public function custom_view_namespace_can_be_added_by_extender()
{
$this->extend(
(new Extend\ViewNamespace)
->add('integration.test', dirname(__FILE__, 3).'/fixtures/views')
(new Extend\View)
->namespace('integration.test', dirname(__FILE__, 3).'/fixtures/views')
);
$this->assertEquals('<html><body>Hello World!</body></html>', trim($this->app()->getContainer()->make(Factory::class)->make('integration.test::test')->render()));