mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-14 12:24:33 +02:00
Code Issues Releases Wiki Activity

Replaced whereExists/whereNotExists with whereIn/whereNotIn (#22)

Browse Source
This commit is contained in:
Tariq Hussein
2020-01-08 21:02:28 +00:00
committed by Franz Liedke
parent 907cc2fbe7
commit b92e5a214f
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
extensions/subscriptions/src/Gambit/SubscriptionGambit.php
View File

@@ -26,14 +26,12 @@ class SubscriptionGambit extends AbstractRegexGambit
{ {
$actor = $search->getActor(); $actor = $search->getActor();
// might be better as `id IN (subquery)`? $method = $negate ? 'whereNotIn' : 'whereIn';
$method = $negate ? 'whereNotExists' : 'whereExists'; $search->getQuery()->$method('id', function ($query) use ($actor, $matches) {
$search->getQuery()->$method(function ($query) use ($actor, $matches) { $query->select('discussion_id')
$query->selectRaw('1') ->from('discussion_user')
->from('discussion_user') ->where('user_id', $actor->id)
->whereColumn('discussions.id', 'discussion_id') ->where('subscription', $matches[1] === 'follow' ? 'follow' : 'ignore');
->where('user_id', $actor->id)
->where('subscription', $matches[1] === 'follow' ? 'follow' : 'ignore');
}); });
} }
} }