mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-30 21:20:24 +02:00
Code Issues Releases Wiki Activity

feat: Default Settings Extender (#3127)

Browse Source 
Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>
This commit is contained in:
Sami Mazouz
2021-10-31 21:09:06 +01:00
committed by GitHub
parent fa82773cc8
commit ba493a90c1
6 changed files with 158 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
framework/core/tests/integration/extenders/SettingsTest.php
View File

@@ -163,6 +163,63 @@ class SettingsTest extends TestCase
$this->assertArrayHasKey('customPrefix.noCustomSetting', $payload['data']['attributes']);
$this->assertEquals('customDefaultModified2', $payload['data']['attributes']['customPrefix.noCustomSetting']);
}
/**
* @test
*/
public function custom_setting_default_prioritizes_extender()
{
$this->extend(
(new Extend\Settings())
->serializeToForum('customPrefix.unavailableCustomSetting3', 'custom-prefix.unavailable_custom_setting3')
->default('custom-prefix.unavailable_custom_setting3', 'extenderDefault')
);
$value = $this->app()
->getContainer()
->make('flarum.settings')
->get('custom-prefix.unavailable_custom_setting3', 'defaultParameterValue');
$this->assertEquals('extenderDefault', $value);
}
/**
* @test
*/
public function custom_setting_default_falls_back_to_parameter()
{
$this->extend(
(new Extend\Settings())
->serializeToForum('customPrefix.unavailableCustomSetting4', 'custom-prefix.unavailable_custom_setting4')
);
$value = $this->app()
->getContainer()
->make('flarum.settings')
->get('custom-prefix.unavailable_custom_setting4', 'defaultParameterValue');
$this->assertEquals('defaultParameterValue', $value);
}
/**
* @test
*/
public function null_custom_setting_returns_null()
{
$this->setting('custom-prefix.custom_null_setting', null);
$this->extend(
(new Extend\Settings())
->default('custom-prefix.custom_null_setting', 'extenderDefault')
);
$value = $this->app()
->getContainer()
->make('flarum.settings')
->get('custom-prefix.custom_null_setting');
$this->assertEquals(null, $value);
}
}
class CustomInvokableClass