mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-08 09:26:34 +02:00
Code Issues Releases Wiki Activity

A bit more cleanup

Browse Source
This commit is contained in:
Alexander Skvortsov
2020-07-09 22:03:55 -04:00
committed by Franz Liedke
parent 1d8662088f
commit bbd8136695
3 changed files with 94 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
js/src/forum/components/PostStream.js
View File

@@ -101,7 +101,6 @@ export default class PostStream extends Component {
}
config(isInitialized, context) {
console.log('redrawing', this.state.visibleStart, this.state.visibleEnd);
if (this.state.needsScroll) {
this.state.needsScroll = false;
const locationType = this.state.locationType;
@@ -260,16 +259,6 @@ export default class PostStream extends Component {
}
}
/**
* Get the distance from the top of the viewport to the point at which we
* would consider a post to be the first one visible.
*
* @return {Integer}
*/
getMarginTop() {
return this.$() && $('#header').outerHeight() + parseInt(this.$().css('margin-top'), 10);
}
/**
* Scroll down to a certain post by number and 'flash' it.
*
@@ -278,7 +267,6 @@ export default class PostStream extends Component {
* @return {jQuery.Deferred}
*/
scrollToNumber(number, noAnimation) {
console.log('scrollToNumber');
const $item = this.$(`.PostStream-item[data-number=${number}]`);
return this.scrollToItem($item, noAnimation).then(this.flashItem.bind(this, $item));
@@ -294,7 +282,6 @@ export default class PostStream extends Component {
* @return {jQuery.Deferred}
*/
scrollToIndex(index, noAnimation, bottom) {
console.log('scrollToIndex');
const $item = this.$(`.PostStream-item[data-index=${index}]`);
return this.scrollToItem($item, noAnimation, true, bottom).then(() => {
@@ -316,7 +303,6 @@ export default class PostStream extends Component {
* @return {jQuery.Deferred}
*/
scrollToItem($item, noAnimation, force, bottom) {
console.log('scrollToItem');
const $container = $('html, body').stop(true);
if ($item.length) {
@@ -340,7 +326,6 @@ export default class PostStream extends Component {
}
return Promise.all([$container.promise(), this.state.loadPromise]).then(() => {
console.log("loaded and scrolled");
this.updateScrubber();
this.state.index = $item.data('index');
m.redraw(true);
@@ -359,4 +344,14 @@ export default class PostStream extends Component {
flashItem($item) {
$item.addClass('flash').one('animationend webkitAnimationEnd', () => $item.removeClass('flash'));
}
/**
* Get the distance from the top of the viewport to the point at which we
* would consider a post to be the first one visible.
*
* @return {Integer}
*/
getMarginTop() {
return this.$() && $('#header').outerHeight() + parseInt(this.$().css('margin-top'), 10);
}
}

168
js/src/forum/components/PostStreamScrubber.js
View File

@@ -87,52 +87,6 @@ export default class PostStreamScrubber extends Component {
);
}
/**
* Get the percentage of the height of the scrubber that should be allocated
* to each post.
*
* @return {Object}
* @property {Number} index The percent per post for posts on either side of
* the visible part of the scrubber.
* @property {Number} visible The percent per post for the visible part of the
* scrubber.
*/
percentPerPost() {
const count = this.state.count() || 1;
const visible = this.state.visible() || 1;
// To stop the handle of the scrollbar from getting too small when there
// are many posts, we define a minimum percentage height for the handle
// calculated from a 50 pixel limit. From this, we can calculate the
// minimum percentage per visible post. If this is greater than the actual
// percentage per post, then we need to adjust the 'before' percentage to
// account for it.
const minPercentVisible = (50 / this.$('.Scrubber-scrollbar').outerHeight()) * 100;
const percentPerVisiblePost = Math.max(100 / count, minPercentVisible / visible);
const percentPerPost = count === visible ? 0 : (100 - percentPerVisiblePost * visible) / (count - visible);
return {
index: percentPerPost,
visible: percentPerVisiblePost,
};
}
/**
* Go to the first post in the discussion.
*/
goToFirst() {
this.state.goToFirst();
this.updateScrubberValues({ animate: true, forceHeightChange: true });
}
/**
* Go to the last post in the discussion.
*/
goToLast() {
this.state.goToLast();
this.updateScrubberValues({ animate: true, forceHeightChange: true });
}
config(isInitialized, context) {
this.state.loadPromise.then(() => this.updateScrubberValues({ animate: true, forceHeightChange: true }));
if (isInitialized) return;
@@ -181,6 +135,67 @@ export default class PostStreamScrubber extends Component {
setTimeout(() => this.scrollListener.start());
}
/**
* Update the scrollbar's position to reflect the current values of the
* index/visible properties.
*
* @param {Boolean} animate
*/
updateScrubberValues(options = {}) {
const index = this.state.index;
const count = this.state.count();
const visible = this.state.visible() || 1;
const percentPerPost = this.percentPerPost();
const $scrubber = this.$();
$scrubber.find(`.Scrubber-index`).text(formatNumber(this.state.sanitizeIndex(Math.max(1, index))));
$scrubber.find(`.Scrubber-description`).text(this.state.description);
$scrubber.toggleClass('disabled', this.state.disabled());
const heights = {};
heights.before = Math.max(0, percentPerPost.index * Math.min(index - 1, count - visible));
heights.handle = Math.min(100 - heights.before, percentPerPost.visible * visible);
heights.after = 100 - heights.before - heights.handle;
// If the state is paused, don't change height on scroll, as the viewport is being scrolled by the JS
// If a height change animation is already in progress, don't adjust height unless overriden
if ((options.fromScroll && this.state.paused) || (this.adjustingHeight && !options.forceHeightChange)) return;
const func = options.animate ? 'animate' : 'css';
this.adjustingHeight = true;
const animationPromises = [];
for (const part in heights) {
const $part = $scrubber.find(`.Scrubber-${part}`);
animationPromises.push(
$part
.stop(true, true)
[func]({ height: heights[part] + '%' }, 'fast')
.promise()
);
// jQuery likes to put overflow:hidden, but because the scrollbar handle
// has a negative margin-left, we need to override.
if (func === 'animate') $part.css('overflow', 'visible');
}
Promise.all(animationPromises).then(() => (this.adjustingHeight = false));
}
/**
* Go to the first post in the discussion.
*/
goToFirst() {
this.state.goToFirst();
this.updateScrubberValues({ animate: true, forceHeightChange: true });
}
/**
* Go to the last post in the discussion.
*/
goToLast() {
this.state.goToLast();
this.updateScrubberValues({ animate: true, forceHeightChange: true });
}
ondestroy() {
this.scrollListener.stop();
$(window).off('resize', this.handlers.onresize);
@@ -205,6 +220,7 @@ export default class PostStreamScrubber extends Component {
}
onmousedown(e) {
e.redraw = false;
this.mouseStart = e.clientY || e.originalEvent.touches[0].clientY;
this.indexStart = this.state.index;
this.dragging = true;
@@ -243,7 +259,6 @@ export default class PostStreamScrubber extends Component {
// content that we want to load those posts.
const intIndex = Math.floor(this.state.index);
this.state.goToIndex(intIndex);
this.updateScrubberValues({ animate: true, forceHeightChange: true });
}
onclick(e) {
@@ -271,47 +286,32 @@ export default class PostStreamScrubber extends Component {
}
/**
* Update the scrollbar's position to reflect the current values of the
* index/visible properties.
* Get the percentage of the height of the scrubber that should be allocated
* to each post.
*
* @param {Boolean} animate
* @return {Object}
* @property {Number} index The percent per post for posts on either side of
* the visible part of the scrubber.
* @property {Number} visible The percent per post for the visible part of the
* scrubber.
*/
updateScrubberValues(options = {}) {
const index = this.state.index;
const count = this.state.count();
percentPerPost() {
const count = this.state.count() || 1;
const visible = this.state.visible() || 1;
const percentPerPost = this.percentPerPost();
const $scrubber = this.$();
$scrubber.find(`.Scrubber-index`).text(formatNumber(this.state.sanitizeIndex(index)));
$scrubber.find(`.Scrubber-description`).text(this.state.description);
$scrubber.toggleClass('disabled', this.state.disabled());
// To stop the handle of the scrollbar from getting too small when there
// are many posts, we define a minimum percentage height for the handle
// calculated from a 50 pixel limit. From this, we can calculate the
// minimum percentage per visible post. If this is greater than the actual
// percentage per post, then we need to adjust the 'before' percentage to
// account for it.
const minPercentVisible = (50 / this.$('.Scrubber-scrollbar').outerHeight()) * 100;
const percentPerVisiblePost = Math.max(100 / count, minPercentVisible / visible);
const percentPerPost = count === visible ? 0 : (100 - percentPerVisiblePost * visible) / (count - visible);
const heights = {};
heights.before = Math.max(0, percentPerPost.index * Math.min(index - 1, count - visible));
heights.handle = Math.min(100 - heights.before, percentPerPost.visible * visible);
heights.after = 100 - heights.before - heights.handle;
console.log("scrolling?");
if (!(options.fromScroll && this.state.paused) && (!this.adjustingHeight || options.forceHeightChange)) {
const func = options.animate ? 'animate' : 'css';
this.adjustingHeight = true;
const animationPromises = [];
console.log("scrolling", heights.before, index)
for (const part in heights) {
const $part = $scrubber.find(`.Scrubber-${part}`);
animationPromises.push(
$part
.stop(true, true)
[func]({ height: heights[part] + '%' }, 'fast')
.promise()
);
// jQuery likes to put overflow:hidden, but because the scrollbar handle
// has a negative margin-left, we need to override.
if (func === 'animate') $part.css('overflow', 'visible');
}
Promise.all(animationPromises).then(() => (this.adjustingHeight = false));
}
return {
index: percentPerPost,
visible: percentPerVisiblePost,
};
}
}

9
js/src/forum/states/PostStreamState.js
View File

@@ -82,7 +82,6 @@ class PostStreamState {
* @return {Promise}
*/
goToNumber(number, noAnimation) {
console.log('goToNumber', number);
// If we want to go to the reply preview, then we will go to the end of the
// discussion and then scroll to the very bottom of the page.
if (number === 'reply') {
@@ -115,7 +114,6 @@ class PostStreamState {
* @return {Promise}
*/
goToIndex(index, noAnimation) {
console.log('goToIndex', index);
this.paused = true;
this.loadPromise = this.loadNearIndex(index);
@@ -140,7 +138,6 @@ class PostStreamState {
* @return {Promise}
*/
loadNearNumber(number) {
console.log('loadNearNumber', number);
if (this.posts().some((post) => post && Number(post.number()) === Number(number))) {
return m.deferred().resolve().promise;
}
@@ -164,9 +161,7 @@ class PostStreamState {
* @return {Promise}
*/
loadNearIndex(index) {
console.log('loadNearIndex', index);
if (index >= this.visibleStart && index <= this.visibleEnd) {
console.log("doing the thing")
return m.deferred().resolve().promise;
}
@@ -182,7 +177,6 @@ class PostStreamState {
* Load the next page of posts.
*/
loadNext() {
console.log('loadNext');
const start = this.visibleEnd;
const end = (this.visibleEnd = this.sanitizeIndex(this.visibleEnd + this.constructor.loadCount));
@@ -206,7 +200,6 @@ class PostStreamState {
* Load the previous page of posts.
*/
loadPrevious() {
console.log('loadPrevious');
const end = this.visibleStart;
const start = (this.visibleStart = this.sanitizeIndex(this.visibleStart - this.constructor.loadCount));
@@ -234,14 +227,12 @@ class PostStreamState {
* @param {Boolean} backwards
*/
loadPage(start, end, backwards) {
console.log('loadPage');
m.redraw();
this.loadPageTimeouts[start] = setTimeout(
() => {
this.loadRange(start, end).then(() => {
if (start >= this.visibleStart && end <= this.visibleEnd) {
console.log('anchoring!');
const anchorIndex = backwards ? this.visibleEnd - 1 : this.visibleStart;
anchorScroll(`.PostStream-item[data-index="${anchorIndex}"]`, () => m.redraw(true));
}