mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-17 14:51:19 +02:00
Code Issues Releases Wiki Activity

Eagerload some needed relations in ListDiscussionsController (#2639)

Browse Source
This commit is contained in:
Sami Mazouz
2021-03-07 22:32:23 +01:00
committed by GitHub
parent 91d5d9c176
commit bc607e089e
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Api/Controller/ListDiscussionsController.php
View File

@@ -110,9 +110,20 @@ class ListDiscussionsController extends AbstractListController
Discussion::setStateUser($actor); Discussion::setStateUser($actor);
// Eager load groups for use in the policies (isAdmin check)
if (in_array('mostRelevantPost.user', $include)) {
$include[] = 'mostRelevantPost.user.groups';
// If the first level of the relationship wasn't explicitly included,
// add it so the code below can look for it
if (! in_array('mostRelevantPost', $include)) {
$include[] = 'mostRelevantPost';
}
}
$results = $results->getResults()->load($include); $results = $results->getResults()->load($include);
if ($relations = array_intersect($include, ['firstPost', 'lastPost'])) { if ($relations = array_intersect($include, ['firstPost', 'lastPost', 'mostRelevantPost'])) {
foreach ($results as $discussion) { foreach ($results as $discussion) {
foreach ($relations as $relation) { foreach ($relations as $relation) {
if ($discussion->$relation) { if ($discussion->$relation) {