From bd3c330217b9640867517e626bcde21ac8042cd6 Mon Sep 17 00:00:00 2001 From: Alexander Skvortsov Date: Thu, 26 Nov 2020 01:54:28 -0500 Subject: [PATCH] Defer clearing discussion list on discussion start This prevents an edge case where `app.discussions` is considered empty while the new page is loading, and as a result, the side pane isn't set as "enabled". Then, if the pane has previously been pinned, when the page loads and the side pane appears, it covers up part of the discussion page. Fixes https://github.com/flarum/core/issues/2471 --- framework/core/js/src/forum/components/DiscussionComposer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/core/js/src/forum/components/DiscussionComposer.js b/framework/core/js/src/forum/components/DiscussionComposer.js index b645ec500..eae52f187 100644 --- a/framework/core/js/src/forum/components/DiscussionComposer.js +++ b/framework/core/js/src/forum/components/DiscussionComposer.js @@ -100,7 +100,7 @@ export default class DiscussionComposer extends ComposerBody { .save(data) .then((discussion) => { this.composer.hide(); - app.discussions.refresh(); + app.discussions.refresh({ deferClear: true }); m.route.set(app.route.discussion(discussion)); }, this.loaded.bind(this)); }