From bded3da42da6d1ead338c4029d272b01f5782138 Mon Sep 17 00:00:00 2001 From: Sami Mazouz Date: Tue, 16 May 2023 19:17:07 +0100 Subject: [PATCH] fix(regression): `queryVisibleTo` accepts nullable actor Signed-off-by: Sami Mazouz --- extensions/tags/src/TagRepository.php | 4 ++-- framework/core/src/Group/GroupRepository.php | 4 ++-- framework/core/src/Post/PostRepository.php | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/extensions/tags/src/TagRepository.php b/extensions/tags/src/TagRepository.php index 50f8a9bcb..8ea1b683b 100644 --- a/extensions/tags/src/TagRepository.php +++ b/extensions/tags/src/TagRepository.php @@ -26,7 +26,7 @@ class TagRepository return Tag::query(); } - public function queryVisibleTo(User $actor): Builder + public function queryVisibleTo(?User $actor = null): Builder { return $this->scopeVisibleTo($this->query(), $actor); } @@ -114,7 +114,7 @@ class TagRepository * @param User|null $user * @return Builder */ - protected function scopeVisibleTo(Builder $query, User $user = null) + protected function scopeVisibleTo(Builder $query, ?User $user = null) { if ($user !== null) { $query->whereVisibleTo($user); diff --git a/framework/core/src/Group/GroupRepository.php b/framework/core/src/Group/GroupRepository.php index 48975533e..30bd06218 100644 --- a/framework/core/src/Group/GroupRepository.php +++ b/framework/core/src/Group/GroupRepository.php @@ -41,7 +41,7 @@ class GroupRepository return $this->scopeVisibleTo($query, $actor)->firstOrFail(); } - public function queryVisibleTo(User $actor = null) + public function queryVisibleTo(?User $actor = null) { return $this->scopeVisibleTo($this->query(), $actor); } @@ -53,7 +53,7 @@ class GroupRepository * @param User|null $actor * @return Builder */ - protected function scopeVisibleTo(Builder $query, User $actor = null) + protected function scopeVisibleTo(Builder $query, ?User $actor = null) { if ($actor !== null) { $query->whereVisibleTo($actor); diff --git a/framework/core/src/Post/PostRepository.php b/framework/core/src/Post/PostRepository.php index 11ad9f308..b764ae8eb 100644 --- a/framework/core/src/Post/PostRepository.php +++ b/framework/core/src/Post/PostRepository.php @@ -29,7 +29,7 @@ class PostRepository * @param User|null $user * @return Builder */ - public function queryVisibleTo(User $user = null) + public function queryVisibleTo(?User $user = null) { $query = $this->query();