mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-19 15:51:16 +02:00
Code Issues Releases Wiki Activity

Add accessibility attributes to loading spinner (#2799)

Browse Source
This commit is contained in:
David Wheatley
2021-04-20 17:25:23 +01:00
committed by GitHub
parent 42a9de5a11
commit c042394d4a
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
framework/core/js/src/common/components/LoadingIndicator.tsx
View File

@@ -53,8 +53,14 @@ export default class LoadingIndicator extends Component<LoadingIndicatorAttrs> {
attrs.containerClassName = classList({ 'LoadingIndicator-container': true, [attrs.containerClassName || '']: true }); attrs.containerClassName = classList({ 'LoadingIndicator-container': true, [attrs.containerClassName || '']: true });
return ( return (
<div {...attrs.containerAttrs} data-size={size} className={attrs.containerClassName}> <div
<div {...attrs}></div> aria-label={app.translator.trans('core.lib.loading_indicator.accessible_label')}
role="status"
{...attrs.containerAttrs}
data-size={size}
className={attrs.containerClassName}
>
<div aria-hidden {...attrs} />
</div> </div>
); );
} }

7
framework/core/locale/core.yml
View File

@@ -483,6 +483,10 @@ core:
permission_denied_message: You do not have permission to do that. permission_denied_message: You do not have permission to do that.
rate_limit_exceeded_message: You're going a little too quickly. Please try again in a few seconds. rate_limit_exceeded_message: You're going a little too quickly. Please try again in a few seconds.
# These translations are used in the loading indicator component.
loading_indicator:
accessible_label: => core.ref.loading
# These translations are used as suffixes when abbreviating numbers. # These translations are used as suffixes when abbreviating numbers.
number_suffix: number_suffix:
kilo_text: K kilo_text: K
@@ -505,7 +509,7 @@ core:
content: content:
javascript_disabled_message: This site is best viewed in a modern browser with JavaScript enabled. javascript_disabled_message: This site is best viewed in a modern browser with JavaScript enabled.
load_error_message: Something went wrong while trying to load the full version of this site. Try hard-refreshing this page to fix the error. load_error_message: Something went wrong while trying to load the full version of this site. Try hard-refreshing this page to fix the error.
loading_text: Loading... loading_text: => core.ref.loading
# Translations in this namespace are displayed in the basic HTML discussion view. # Translations in this namespace are displayed in the basic HTML discussion view.
discussion: discussion:
@@ -624,6 +628,7 @@ core:
icon: Icon icon: Icon
icon_text: "Enter the name of any <a>FontAwesome</a> icon class, <em>including</em> the <code>fas fa-</code> prefix." icon_text: "Enter the name of any <a>FontAwesome</a> icon class, <em>including</em> the <code>fas fa-</code> prefix."
load_more: Load More load_more: Load More
loading: Loading...
log_in: Log In log_in: Log In
log_out: Log Out log_out: Log Out
mark_all_as_read: Mark All as Read mark_all_as_read: Mark All as Read