mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-12 19:34:18 +02:00
Code Issues Releases Wiki Activity

Tests: Comply with default permissions

Browse Source 
Before transactions, each test class would need to explicitly state starting state for permissions, which made the initial permission configuration somewhat arbitrary. Now, we might as well use the initial state of the default installation.

One of the User show_test tests has been commented out until
This commit is contained in:
Alexander Skvortsov
2021-01-07 11:24:52 -05:00
parent ae280016e7
commit c1aa1455d3
2 changed files with 68 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/integration/extenders/PolicyTest.php
View File

@@ -137,19 +137,19 @@ class PolicyTest extends TestCase
/**
* @test
*/
public function regular_user_cant_start_discussions_by_default()
public function regular_user_can_start_discussions_by_default()
{
$this->app();
$user = User::find(2);
$this->assertEquals(false, $user->can('startDiscussion'));
$this->assertEquals(true, $user->can('startDiscussion'));
}
/**
* @test
*/
public function regular_user_can_start_discussions_if_granted_by_global_policy()
public function regular_user_cant_start_discussions_if_blocked_by_global_policy()
{
$this->extend(
(new Extend\Policy)
@@ -160,7 +160,7 @@ class PolicyTest extends TestCase
$user = User::find(2);
$this->assertEquals(true, $user->can('startDiscussion'));
$this->assertEquals(false, $user->can('startDiscussion'));
}
/**
@@ -177,7 +177,7 @@ class PolicyTest extends TestCase
$user = User::find(2);
$this->assertEquals(false, $user->can('startDiscussion', Discussion::find(1)));
$this->assertEquals(true, $user->can('startDiscussion', Discussion::find(1)));
}
/**
@@ -260,7 +260,7 @@ class GlobalStartDiscussionPolicy extends AbstractPolicy
{
protected function startDiscussion(User $user)
{
return $this->allow();
return $this->deny();
}
}