mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-11 19:04:29 +02:00
Code Issues Releases Wiki Activity

Upgrade to Ember 1.11-beta.1

Browse Source 
HTMLBars goodness! Since there was some breakage and a lot of fiddling
around to get some things working, I took this opportunity to do a big
cleanup of the whole Ember app. I accidentally worked on some new
features too :3

Note that the app is still broken right now, pending on
https://github.com/emberjs/ember.js/issues/10401

Cleanup:
- Restructuring of components
- Consolidation of some stuff into mixins, cleanup of some APIs that
will be public
- Change all instances of .property() / .observes() / .on() to
Ember.computed() / Ember.observer() / Ember.on() respectively (I think
it is more readable)
- More comments
- Start conforming to a code style (2 spaces for indentation)

New features:
- Post hiding/restoring
- Mark individual discussions as read by clicking
- Clicking on a read discussion jumps to the end
- Mark all discussions as read
- Progressively mark the discussion as read as the page is scrolled
- Unordered list post formatting
- Post permalink popup

Demo once that Ember regression is fixed!
This commit is contained in:
Toby Zerner
2015-02-10 18:05:40 +10:30
parent cf88fda8c8
commit c28307903b
164 changed files with 4623 additions and 4587 deletions
Download Patch File Download Diff File Expand all files Collapse all files

90
ember/app/mixins/paneable.js
View File

@@ -1,59 +1,57 @@
import Ember from 'ember';
// This mixin defines a "paneable" controller - this is, one that has a
// portion of its interface that can be turned into a pane which slides out
// from the side of the screen. This is useful, for instance, when you have
// nested routes (index > discussion) and want to have the parent
// route's interface transform into a side pane when entering the child route.
/**
This mixin defines a "paneable" controller - this is, one that has a portion
of its interface that can be turned into a pane which slides out from the
side of the screen. This is useful, for instance, when you have nested
routes (index > discussion) and want to have the parent route's interface
transform into a side pane when entering the child route.
*/
export default Ember.Mixin.create({
needs: ['application'],
needs: ['application'],
// Whether or not the "paneable" interface element is paned.
paned: false,
// Whether or not the "paneable" interface element is paned.
paned: false,
// Whether or not the pane should be visible on screen.
paneShowing: false,
paneHideTimeout: null,
// Whether or not the pane should be visible on screen.
paneShowing: false,
paneHideTimeout: null,
// Whether or not the pane is always visible on screen, even when the
// mouse is taken away.
panePinned: localStorage.getItem('panePinned'),
// Whether or not the pane is always visible on screen, even when the
// mouse is taken away.
panePinned: localStorage.getItem('panePinned'),
// Disable the paneable behaviour completely, regardless of if it is
// paned, showing, or pinned.
paneDisabled: false,
// Disable the paneable behaviour completely, regardless of if it is
// paned, showing, or pinned.
paneDisabled: false,
paneIsShowing: function() {
return this.get('paned') && this.get('paneShowing') && !this.get('paneDisabled');
}.property('paned', 'paneShowing', 'paneDisabled'),
paneEnabled: Ember.computed.not('paneDisabled'),
paneIsShowing: Ember.computed.and('paned', 'paneShowing', 'paneEnabled'),
paneIsPinned: Ember.computed.and('paned', 'panePinned', 'paneEnabled'),
paneIsPinned: function() {
return this.get('paned') && this.get('panePinned') && !this.get('paneDisabled');
}.property('paned', 'panePinned', 'paneDisabled'),
// Tell the application controller when we pin/unpin the pane so that
// other parts of the interface can respond appropriately.
paneIsPinnedChanged: Ember.observer('paneIsPinned', function() {
this.set('controllers.application.panePinned', this.get('paneIsPinned'));
}),
// Tell the application controller when we pin/unpin the pane so that
// other parts of the interface can respond appropriately.
paneIsPinnedChanged: function() {
this.set('controllers.application.panePinned', this.get('paneIsPinned'));
}.observes('paneIsPinned'),
actions: {
showPane: function() {
if (this.get('paned')) {
clearTimeout(this.get('paneHideTimeout'));
this.set('paneShowing', true);
}
},
actions: {
showPane: function() {
if (this.get('paned')) {
clearTimeout(this.get('paneHideTimeout'));
this.set('paneShowing', true);
}
},
hidePane: function(delay) {
var controller = this;
controller.set('paneHideTimeout', setTimeout(function() {
controller.set('paneShowing', false);
}, delay || 250));
},
hidePane: function(delay) {
var controller = this;
controller.set('paneHideTimeout', setTimeout(function() {
controller.set('paneShowing', false);
}, delay || 250));
},
togglePinned: function() {
localStorage.setItem('panePinned', this.toggleProperty('panePinned') || '');
}
}
togglePinned: function() {
localStorage.setItem('panePinned', this.toggleProperty('panePinned') || '');
}
}
});