mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-05 07:57:46 +02:00
Code Issues Releases Wiki Activity

Add a workaround for the blank SelectDropdown issue.

Browse Source 
Workaround explained in the code.
This commit is contained in:
Alexander Skvortsov
2020-09-10 01:08:38 -04:00
committed by Franz Liedke
parent 29d995de45
commit cbd9c8dd4f
1 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
js/src/common/components/SelectDropdown.js
View File

@@ -2,7 +2,25 @@ import Dropdown from './Dropdown';
import icon from '../helpers/icon';
/**
* The `SelectDropdown` component is the same as a `Dropdown`, except the toggle
* Determines via a vnode is currently "active".
* Due to changes in Mithril 2, attrs will not be instantiated until AFTER view()
* is initially called on the parent component, so we can not always depend on the
* active attr to determine which element should be displayed as the "active child".
*
* This is a temporary patch, and as so, is not exported / placed in utils.
*/
function isActive(vnode) {
const tag = vnode.tag;
if ('initAttrs' in tag) {
tag.initAttrs(vnode.attrs);
}
return 'isActive' in tag ? tag.isActive(vnode.attrs) : vnode.attrs.active;
}
/**
* The `SelectDropdown` csomponent is the same as a `Dropdown`, except the toggle
* button's label is set as the label of the first child which has a truthy
* `active` prop.
*
@@ -21,7 +39,7 @@ export default class SelectDropdown extends Dropdown {
}
getButtonContent(children) {
const activeChild = children.filter((child) => child.attrs.active)[0];
const activeChild = children.filter(isActive)[0];
let label = (activeChild && activeChild.children) || this.attrs.defaultLabel;
if (label instanceof Array) label = label[0];