From ccbfb0754d2fa1a8fb67c9622fed9310b55c959e Mon Sep 17 00:00:00 2001
From: Toby Zerner <toby.zerner@gmail.com>
Date: Thu, 6 Aug 2015 13:59:09 +0930
Subject: [PATCH] Throw an exception if discussion not found

closes flarum/core#208
---
 framework/core/src/Api/Response.php                   |  5 +++++
 framework/core/src/Forum/Actions/DiscussionAction.php | 10 +++++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/framework/core/src/Api/Response.php b/framework/core/src/Api/Response.php
index 8c89799a5..27c97af4f 100644
--- a/framework/core/src/Api/Response.php
+++ b/framework/core/src/Api/Response.php
@@ -13,4 +13,9 @@ class Response
     {
         return json_decode($this->response->getBody());
     }
+
+    public function getStatusCode()
+    {
+        return $this->response->getStatusCode();
+    }
 }
diff --git a/framework/core/src/Forum/Actions/DiscussionAction.php b/framework/core/src/Forum/Actions/DiscussionAction.php
index ee545cdca..1de63268b 100644
--- a/framework/core/src/Forum/Actions/DiscussionAction.php
+++ b/framework/core/src/Forum/Actions/DiscussionAction.php
@@ -1,6 +1,7 @@
 <?php namespace Flarum\Forum\Actions;
 
 use Psr\Http\Message\ServerRequestInterface as Request;
+use Flarum\Http\RouteNotFoundException;
 
 class DiscussionAction extends ClientAction
 {
@@ -70,6 +71,13 @@ class DiscussionAction extends ClientAction
         $actor = app('flarum.actor');
         $action = 'Flarum\Api\Actions\Discussions\ShowAction';
 
-        return $this->apiClient->send($actor, $action, $params)->getBody();
+        $response = $this->apiClient->send($actor, $action, $params);
+        $statusCode = $response->getStatusCode();
+
+        if ($statusCode === 404) {
+            throw new RouteNotFoundException;
+        }
+
+        return $response->getBody();
     }
 }