mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-31 05:30:38 +02:00
Code Issues Releases Wiki Activity

Wire up new error handling stack

Browse Source
This commit is contained in:
Franz Liedke
2019-08-09 20:38:51 +02:00
parent 3417f5a77e
commit cfbaa84fbc
7 changed files with 253 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
tests/unit/Foundation/ErrorHandling/ExceptionHandler/IlluminateValidationExceptionHandlerTest.php Normal file
View File

@@ -0,0 +1,53 @@
<?php
/*
* This file is part of Flarum.
*
* (c) Toby Zerner <toby.zerner@gmail.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Flarum\Tests\unit\Foundation\ErrorHandling\ExceptionHandler;
use Flarum\Foundation\ErrorHandling\ExceptionHandler\IlluminateValidationExceptionHandler;
use Illuminate\Translation\ArrayLoader;
use Illuminate\Translation\Translator;
use Illuminate\Validation\Factory;
use Illuminate\Validation\ValidationException;
use PHPUnit\Framework\TestCase;
class IlluminateValidationExceptionHandlerTest extends TestCase
{
private $handler;
public function setUp()
{
$this->handler = new IlluminateValidationExceptionHandler;
}
public function test_it_creates_the_desired_output()
{
$exception = new ValidationException($this->makeValidator(['foo' => ''], ['foo' => 'required']));
$error = $this->handler->handle($exception);
$this->assertEquals(422, $error->getStatusCode());
$this->assertEquals('validation_error', $error->getType());
$this->assertEquals([
[
'detail' => 'validation.required',
'source' => ['pointer' => '/data/attributes/foo']
]
], $error->getDetails());
}
private function makeValidator($data = [], $rules = [])
{
$translator = new Translator(new ArrayLoader(), 'en');
$factory = new Factory($translator);
return $factory->make($data, $rules);
}
}

47
tests/unit/Foundation/ErrorHandling/ExceptionHandler/ValidationExceptionHandlerTest.php Normal file
View File

@@ -0,0 +1,47 @@
<?php
/*
* This file is part of Flarum.
*
* (c) Toby Zerner <toby.zerner@gmail.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Flarum\Tests\unit\Foundation\ErrorHandling\ExceptionHandler;
use Flarum\Foundation\ErrorHandling\ExceptionHandler\ValidationExceptionHandler;
use Flarum\Foundation\ValidationException;
use PHPUnit\Framework\TestCase;
class ValidationExceptionHandlerTest extends TestCase
{
private $handler;
public function setUp()
{
$this->handler = new ValidationExceptionHandler;
}
public function test_managing_exceptions()
{
$error = $this->handler->handle(new ValidationException(
['foo' => 'Attribute error'],
['bar' => 'Relationship error']
));
$this->assertEquals(422, $error->getStatusCode());
$this->assertEquals('validation_error', $error->getType());
$this->assertEquals([
[
'detail' => 'Attribute error',
'source' => ['pointer' => '/data/attributes/foo']
],
[
'detail' => 'Relationship error',
'source' => ['pointer' => '/data/relationships/bar']
]
], $error->getDetails());
}
}