mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-12 12:26:23 +02:00
Code Issues Releases Wiki Activity

chore: 1.2 JS clean-up (#3214)

Browse Source 
* fix: `extend.ts` TS error

* docs: fix incorrect JS docblocks

* chore: simplify some code

* chore: remove usages of prefixed JS function

* chore: consistent empty return types

* chore: format

* fix: typing errors

* chore: remove unneeded `@public` docblock modifiers

* Apply suggestions from code review

* Update js/src/forum/utils/slidable.js

Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>
This commit is contained in:
David Wheatley
2021-12-27 19:58:18 +01:00
committed by GitHub
parent 4df72e5ac6
commit d268894e61
60 changed files with 292 additions and 355 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
js/src/forum/components/DiscussionListItem.js
View File

@ -143,7 +143,7 @@ export default class DiscussionListItem extends Component {
/**
* Determine whether or not the discussion is currently being viewed.
*
* @return {Boolean}
* @return {boolean}
*/
active() {
return app.current.matches(DiscussionPage, { discussion: this.attrs.discussion });
@ -154,7 +154,7 @@ export default class DiscussionListItem extends Component {
* should be displayed instead of information about the most recent reply to
* the discussion.
*
* @return {Boolean}
* @return {boolean}
*/
showFirstPost() {
return ['newest', 'oldest'].indexOf(this.attrs.params.sort) !== -1;
@ -164,7 +164,7 @@ export default class DiscussionListItem extends Component {
* Determine whether or not the number of replies should be shown instead of
* the number of unread posts.
*
* @return {Boolean}
* @return {boolean}
*/
showRepliesCount() {
return this.attrs.params.sort === 'replies';
@ -186,7 +186,7 @@ export default class DiscussionListItem extends Component {
* Build an item list of info for a discussion listing. By default this is
* just the first/last post indicator.
*
* @return {ItemList}
* @return {ItemList<import('mithril').Children>}
*/
infoItems() {
const items = new ItemList();