mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-04 15:37:51 +02:00
Code Issues Releases Wiki Activity

fix(a11y): false aria-hidden causes inconsistent behavior (#4074)

Browse Source
This commit is contained in:
雨
2024-10-22 16:28:43 +08:00
committed by GitHub
parent f97c67e2f9
commit d3002106d5
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
framework/core/js/src/admin/components/UserListPage.tsx
View File

@@ -318,7 +318,7 @@ export default class UserListPage extends AdminPage {
) )
); );
emailAddress.attr('aria-hidden', visible ? 'false' : 'true'); emailAddress.attr('aria-hidden', visible ? null : 'true');
if (visible) { if (visible) {
emailToggleButtonIcon.addClass('fa-eye'); emailToggleButtonIcon.addClass('fa-eye');

2
framework/core/js/src/common/components/ModalManager.tsx
View File

@@ -98,7 +98,7 @@ export default class ModalManager extends Component<IModalManagerAttrs> {
// See: http://web-accessibility.carnegiemuseums.org/code/dialogs/ // See: http://web-accessibility.carnegiemuseums.org/code/dialogs/
if (!this.attrs.state.isModalOpen()) { if (!this.attrs.state.isModalOpen()) {
document.getElementById('app')?.setAttribute('aria-hidden', 'false'); document.getElementById('app')?.removeAttribute('aria-hidden');
this.focusTrap!.deactivate?.(); this.focusTrap!.deactivate?.();
clearAllBodyScrollLocks(); clearAllBodyScrollLocks();