1
0
mirror of https://github.com/flarum/core.git synced 2025-08-09 09:57:06 +02:00

PERF: avoid reinstantiation of event subscribers

This commit is contained in:
Toby Zerner
2015-07-27 11:54:52 +09:30
parent 3192ef4fe3
commit d8cb3c7605
9 changed files with 23 additions and 23 deletions

View File

@@ -14,10 +14,10 @@ class AddApiAttributes
{ {
public function subscribe($events) public function subscribe($events)
{ {
$events->listen(ApiRelationship::class, __CLASS__.'@addTagsRelationship'); $events->listen(ApiRelationship::class, [$this, 'addTagsRelationship']);
$events->listen(WillSerializeData::class, __CLASS__.'@loadTagsRelationship'); $events->listen(WillSerializeData::class, [$this, 'loadTagsRelationship']);
$events->listen(BuildApiAction::class, __CLASS__.'@includeTagsRelationship'); $events->listen(BuildApiAction::class, [$this, 'includeTagsRelationship']);
$events->listen(ApiAttributes::class, __CLASS__.'@addAttributes'); $events->listen(ApiAttributes::class, [$this, 'addAttributes']);
} }
public function addTagsRelationship(ApiRelationship $event) public function addTagsRelationship(ApiRelationship $event)

View File

@@ -9,9 +9,9 @@ class AddClientAssets
{ {
public function subscribe(Dispatcher $events) public function subscribe(Dispatcher $events)
{ {
$events->listen(RegisterLocales::class, __CLASS__.'@addLocale'); $events->listen(RegisterLocales::class, [$this, 'addLocale']);
$events->listen(BuildClientView::class, __CLASS__.'@addAssets'); $events->listen(BuildClientView::class, [$this, 'addAssets']);
$events->listen(RegisterForumRoutes::class, __CLASS__.'@addRoutes'); $events->listen(RegisterForumRoutes::class, [$this, 'addRoutes']);
} }
public function addLocale(RegisterLocales $event) public function addLocale(RegisterLocales $event)

View File

@@ -8,7 +8,7 @@ class AddModelRelationship
{ {
public function subscribe($events) public function subscribe($events)
{ {
$events->listen(ModelRelationship::class, __CLASS__.'@addTagsRelationship'); $events->listen(ModelRelationship::class, [$this, 'addTagsRelationship']);
} }
public function addTagsRelationship(ModelRelationship $event) public function addTagsRelationship(ModelRelationship $event)

View File

@@ -7,7 +7,7 @@ class AddTagGambit
{ {
public function subscribe(Dispatcher $events) public function subscribe(Dispatcher $events)
{ {
$events->listen(RegisterDiscussionGambits::class, __CLASS__.'@registerTagGambit'); $events->listen(RegisterDiscussionGambits::class, [$this, 'registerTagGambit']);
} }
public function registerTagGambit(RegisterDiscussionGambits $event) public function registerTagGambit(RegisterDiscussionGambits $event)

View File

@@ -9,8 +9,8 @@ class ConfigureDiscussionPermissions
{ {
public function subscribe($events) public function subscribe($events)
{ {
$events->listen(ScopeModelVisibility::class, __CLASS__.'@scopeDiscussionVisibility'); $events->listen(ScopeModelVisibility::class, [$this, 'scopeDiscussionVisibility']);
$events->listen(ModelAllow::class, __CLASS__.'@allowDiscussionPermissions'); $events->listen(ModelAllow::class, [$this, 'allowDiscussionPermissions']);
} }
public function scopeDiscussionVisibility(ScopeModelVisibility $event) public function scopeDiscussionVisibility(ScopeModelVisibility $event)

View File

@@ -8,8 +8,8 @@ class ConfigureTagPermissions
{ {
public function subscribe($events) public function subscribe($events)
{ {
$events->listen(ScopeModelVisibility::class, __CLASS__.'@scopeTagVisibility'); $events->listen(ScopeModelVisibility::class, [$this, 'scopeTagVisibility']);
$events->listen(ModelAllow::class, __CLASS__.'@allowStartDiscussion'); $events->listen(ModelAllow::class, [$this, 'allowStartDiscussion']);
} }
public function scopeTagVisibility(ScopeModelVisibility $event) public function scopeTagVisibility(ScopeModelVisibility $event)

View File

@@ -9,8 +9,8 @@ class LogDiscussionTagged
{ {
public function subscribe(Dispatcher $events) public function subscribe(Dispatcher $events)
{ {
$events->listen(RegisterPostTypes::class, __CLASS__.'@registerPostType'); $events->listen(RegisterPostTypes::class, [$this, 'registerPostType']);
$events->listen(DiscussionWasTagged::class, __CLASS__.'@whenDiscussionWasTagged'); $events->listen(DiscussionWasTagged::class, [$this, 'whenDiscussionWasTagged']);
} }
public function registerPostType(RegisterPostTypes $event) public function registerPostType(RegisterPostTypes $event)

View File

@@ -10,7 +10,7 @@ class PersistData
{ {
public function subscribe($events) public function subscribe($events)
{ {
$events->listen(DiscussionWillBeSaved::class, __CLASS__.'@whenDiscussionWillBeSaved'); $events->listen(DiscussionWillBeSaved::class, [$this, 'whenDiscussionWillBeSaved']);
} }
public function whenDiscussionWillBeSaved(DiscussionWillBeSaved $event) public function whenDiscussionWillBeSaved(DiscussionWillBeSaved $event)

View File

@@ -15,14 +15,14 @@ class UpdateTagMetadata
{ {
public function subscribe($events) public function subscribe($events)
{ {
$events->listen(DiscussionWasStarted::class, __CLASS__.'@whenDiscussionWasStarted'); $events->listen(DiscussionWasStarted::class, [$this, 'whenDiscussionWasStarted']);
$events->listen(DiscussionWasTagged::class, __CLASS__.'@whenDiscussionWasTagged'); $events->listen(DiscussionWasTagged::class, [$this, 'whenDiscussionWasTagged']);
$events->listen(DiscussionWasDeleted::class, __CLASS__.'@whenDiscussionWasDeleted'); $events->listen(DiscussionWasDeleted::class, [$this, 'whenDiscussionWasDeleted']);
$events->listen(PostWasPosted::class, __CLASS__.'@whenPostWasPosted'); $events->listen(PostWasPosted::class, [$this, 'whenPostWasPosted']);
$events->listen(PostWasDeleted::class, __CLASS__.'@whenPostWasDeleted'); $events->listen(PostWasDeleted::class, [$this, 'whenPostWasDeleted']);
$events->listen(PostWasHidden::class, __CLASS__.'@whenPostWasHidden'); $events->listen(PostWasHidden::class, [$this, 'whenPostWasHidden']);
$events->listen(PostWasRestored::class, __CLASS__.'@whenPostWasRestored'); $events->listen(PostWasRestored::class, [$this, 'whenPostWasRestored']);
} }
public function whenDiscussionWasStarted(DiscussionWasStarted $event) public function whenDiscussionWasStarted(DiscussionWasStarted $event)