mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-10-12 07:24:27 +02:00
Code Issues Releases Wiki Activity

Gracefully handle non-existent/deleted users during rendering

Browse Source
This commit is contained in:
Toby Zerner
2015-05-03 12:08:41 +09:30
parent f2e2d59e6f
commit d9d190b772
4 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
js/forum/src/components/discussion-list.js
View File

@@ -99,10 +99,10 @@ export default class DiscussionList extends Component {
return m('div', [
m('ul.discussions-list', [
this.discussions().map(discussion => {
var startUser = discussion.startUser()
var isUnread = discussion.isUnread()
var displayUnread = this.countType() !== 'replies' && isUnread
var jumpTo = Math.min(discussion.lastPostNumber(), (discussion.readNumber() || 0) + 1)
var startUser = discussion.startUser();
var isUnread = discussion.isUnread();
var displayUnread = this.countType() !== 'replies' && isUnread;
var jumpTo = Math.min(discussion.lastPostNumber(), (discussion.readNumber() || 0) + 1);
var controls = discussion.controls(this).toArray();
@@ -116,13 +116,13 @@ export default class DiscussionList extends Component {
buttonClass: 'btn btn-default btn-icon btn-sm btn-naked',
menuClass: 'pull-right'
}) : '',
m('a.author', {
href: app.route('user', { username: startUser.username() }),
m((startUser ? 'a' : 'span')+'.author', {
href: startUser ? app.route('user', { username: startUser.username() }) : undefined,
config: function(element, isInitialized, context) {
$(element).tooltip({ placement: 'right' })
m.route.call(this, element)
},
title: 'Started by '+startUser.username()+' '+humanTime(discussion.startTime())
title: 'Started by '+(startUser ? startUser.username() : '[deleted]')+' '+humanTime(discussion.startTime())
}, [
avatar(startUser, {title: ''})
]),