From da9272e870ddad693fd56f2cc0de115e2e73869d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20Klabbers?= Date: Fri, 13 Jul 2018 10:32:57 +0200 Subject: [PATCH] Update PULL_REQUEST_TEMPLATE.md adding a requirement list adding related required changes added comment description --- .../core/.github/PULL_REQUEST_TEMPLATE.md | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/framework/core/.github/PULL_REQUEST_TEMPLATE.md b/framework/core/.github/PULL_REQUEST_TEMPLATE.md index a4cf8816e..6127e529c 100644 --- a/framework/core/.github/PULL_REQUEST_TEMPLATE.md +++ b/framework/core/.github/PULL_REQUEST_TEMPLATE.md @@ -1,10 +1,24 @@ + + **Fixes #0000** **Changes proposed in this pull request:** - + **Reviewers should focus on:** - + **Screenshot** + +**Confirmed** + +- [ ] for visual or frontend changes that the changes work as intended via visual confirmation on a local flarum installation. +- [ ] for php changes that the unit tests are all AOK (green) by running them locally (`php vendor/bin/phpunit`). + +**Required changes:** + +- **Docs**: +- **Core extensions**: