From f005b9e0316275598270e9b26ccd0968e731621b Mon Sep 17 00:00:00 2001 From: Clark Winkelmann Date: Sun, 6 Nov 2022 19:27:32 +0100 Subject: [PATCH] Fix tag discussion count decreased by 2 when hiding before deleting (#3660) --- extensions/tags/src/Listener/UpdateTagMetadata.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/extensions/tags/src/Listener/UpdateTagMetadata.php b/extensions/tags/src/Listener/UpdateTagMetadata.php index 87366b86f..9fac2d079 100755 --- a/extensions/tags/src/Listener/UpdateTagMetadata.php +++ b/extensions/tags/src/Listener/UpdateTagMetadata.php @@ -66,7 +66,9 @@ class UpdateTagMetadata */ public function whenDiscussionIsDeleted(Deleted $event) { - $this->updateTags($event->discussion, -1); + // If already soft deleted when permanently deleted, the -1 delta has already been applied in Hidden listener + $delta = $event->discussion->hidden_at ? 0 : -1; + $this->updateTags($event->discussion, $delta); $event->discussion->tags()->detach(); }