1
0
mirror of https://github.com/flarum/core.git synced 2025-07-25 10:41:24 +02:00

Improve client XHR error handling

The default XHR error handler produce an alert which is appropriate to the response status code. It can be overridden per-request (by specifying the `errorHandler` option) so that the alert can be suppressed or displayed in a different position (e.g. inside a modal).

ref #118
This commit is contained in:
Toby Zerner
2015-10-20 12:48:26 +10:30
parent 0952651cf3
commit f2dbb96e84
26 changed files with 192 additions and 175 deletions

View File

@@ -85,13 +85,12 @@ export default class EditGroupModal extends Modal {
namePlural: this.namePlural(),
color: this.color(),
icon: this.icon()
}).then(
() => this.hide(),
(response) => {
}, {errorHandler: this.onerror.bind(this)})
.then(this.hide.bind(this))
.catch(() => {
this.loading = false;
this.handleErrors(response);
}
);
m.redraw();
});
}
deleteGroup() {

View File

@@ -68,11 +68,8 @@ export default class SettingsModal extends Modal {
this.loading = true;
saveSettings(this.dirty()).then(
() => this.hide(),
() => {
this.loading = false;
m.redraw();
}
this.hide.bind(this),
this.loaded.bind(this)
);
}
}