From f7b5b7d21d9843fc5eab3b199a4e496508c0f770 Mon Sep 17 00:00:00 2001
From: Michael Daly <hello@michaeldaly.me>
Date: Thu, 1 Feb 2018 23:06:41 +0000
Subject: [PATCH] Fix issue #1249 and do not show or count private discussions
 in Tags summary.

---
 .../tags/src/Listener/UpdateTagMetadata.php    | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/extensions/tags/src/Listener/UpdateTagMetadata.php b/extensions/tags/src/Listener/UpdateTagMetadata.php
index 9b41a2031..14dffebaf 100755
--- a/extensions/tags/src/Listener/UpdateTagMetadata.php
+++ b/extensions/tags/src/Listener/UpdateTagMetadata.php
@@ -114,16 +114,18 @@ class UpdateTagMetadata
             $tags = $discussion->tags;
         }
 
-        foreach ($tags as $tag) {
-            $tag->discussions_count += $delta;
+        if (! $discussion->is_private) {
+            foreach ($tags as $tag) {
+                $tag->discussions_count += $delta;
 
-            if ($discussion->last_time > $tag->last_time) {
-                $tag->setLastDiscussion($discussion);
-            } elseif ($discussion->id == $tag->last_discussion_id) {
-                $tag->refreshLastDiscussion();
+                if ($discussion->last_time > $tag->last_time) {
+                    $tag->setLastDiscussion($discussion);
+                } elseif ($discussion->id == $tag->last_discussion_id) {
+                    $tag->refreshLastDiscussion();
+                }
+
+                $tag->save();
             }
-
-            $tag->save();
         }
     }
 }