mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-06 08:27:42 +02:00
Code Issues Releases Wiki Activity

test: prevent false negatives

Browse Source
This commit is contained in:
Sami Mazouz
2024-10-21 19:16:12 +01:00
parent 8219e76da4
commit f97c67e2f9
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/tags/tests/integration/api/tags/ListTest.php
View File

@@ -79,7 +79,7 @@ class ListTest extends TestCase
// 6, 7, 8 aren't included because child access shouldnt work unless parent // 6, 7, 8 aren't included because child access shouldnt work unless parent
// access is also given. // access is also given.
$ids = Arr::pluck($data, 'id'); $ids = Arr::pluck($data, 'id');
$this->assertEquals(['1', '2', '3', '4', '9', '10', '11'], $ids); $this->assertEqualsCanonicalizing(['1', '2', '3', '4', '9', '10', '11'], $ids);
} }
#[Test] #[Test]
@@ -103,8 +103,8 @@ class ListTest extends TestCase
// 5 isnt included because parent access doesnt necessarily give child access // 5 isnt included because parent access doesnt necessarily give child access
// 6, 7, 8 aren't included because child access shouldnt work unless parent // 6, 7, 8 aren't included because child access shouldnt work unless parent
// access is also given. // access is also given.
$this->assertEquals(['1', '2', '3', '4', '9', '10', '11'], Arr::pluck($data, 'id')); $this->assertEqualsCanonicalizing(['1', '2', '3', '4', '9', '10', '11'], Arr::pluck($data, 'id'));
$this->assertEquals( $this->assertEqualsCanonicalizing(
$expectedIncludes, $expectedIncludes,
collect($data) collect($data)
->pluck('relationships.'.$include.'.data') ->pluck('relationships.'.$include.'.data')