From fb83f8c59c0c791dc13046d0d052dd8aa16bab50 Mon Sep 17 00:00:00 2001 From: Franz Liedke Date: Fri, 11 Sep 2020 16:29:44 +0200 Subject: [PATCH] TextFormatterPreview: Pass in content callback This makes the component itself less dependent on global state, which has benefits for testability and reusability. --- js/src/forum/components/CommentPost.js | 4 +++- js/src/forum/components/TextFormatterPreview.js | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/js/src/forum/components/CommentPost.js b/js/src/forum/components/CommentPost.js index 5d19a1f27..1568f9ccd 100644 --- a/js/src/forum/components/CommentPost.js +++ b/js/src/forum/components/CommentPost.js @@ -50,7 +50,9 @@ export default class CommentPost extends Post {
, -
{this.isEditing() ? : m.trust(this.attrs.post.contentHtml())}
, +
+ {this.isEditing() ? app.composer.fields.content()} /> : m.trust(this.attrs.post.contentHtml())} +
, ]); } diff --git a/js/src/forum/components/TextFormatterPreview.js b/js/src/forum/components/TextFormatterPreview.js index a3de7dd9c..203c04b0f 100644 --- a/js/src/forum/components/TextFormatterPreview.js +++ b/js/src/forum/components/TextFormatterPreview.js @@ -14,7 +14,7 @@ export default class TextFormatterPreview extends Component { // body with a preview. let preview; const updatePreview = () => { - const content = app.composer.fields.content(); + const content = this.attrs.content(); if (preview === content) return;