From fbe1a48bec99db52a570621fca61dfb7bf1097b4 Mon Sep 17 00:00:00 2001
From: Alexander Skvortsov <sasha.skvortsov109@gmail.com>
Date: Tue, 4 Jan 2022 21:13:00 -0500
Subject: [PATCH] Fix `echo` statements not showing up in debug modals or
 console trace

This was accidentially introduced in the recent Application permissions refactor, where `formattedError`was changed to always be a string array.
---
 js/src/common/Application.tsx                  | 6 +++++-
 js/src/common/components/RequestErrorModal.tsx | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/js/src/common/Application.tsx b/js/src/common/Application.tsx
index e9c930d4c..db784e13c 100644
--- a/js/src/common/Application.tsx
+++ b/js/src/common/Application.tsx
@@ -547,7 +547,11 @@ export default class Application {
 
         console.group(`${method} ${url} ${status}`);
 
-        console.error(...(formattedErrors || [e]));
+        if (formattedErrors.length) {
+          console.error(...formattedErrors);
+        } else {
+          console.error(e)
+        }
 
         console.groupEnd();
       }
diff --git a/js/src/common/components/RequestErrorModal.tsx b/js/src/common/components/RequestErrorModal.tsx
index 895ef5acc..abada7796 100644
--- a/js/src/common/components/RequestErrorModal.tsx
+++ b/js/src/common/components/RequestErrorModal.tsx
@@ -22,7 +22,7 @@ export default class RequestErrorModal<CustomAttrs extends IRequestErrorModalAtt
 
     // If the error is already formatted, just add line endings;
     // else try to parse it as JSON and stringify it with indentation
-    if (formattedError) {
+    if (formattedError.length) {
       responseText = formattedError.join('\n\n');
     } else if (error.response) {
       responseText = JSON.stringify(error.response, null, 2);