mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-31 20:02:06 +02:00
Code Issues Releases Wiki Activity
8,263 Commits 89 Branches 54 Tags
as/better-dist-typings
Commit Graph

8263 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Franz Liedke
042cc54312 Collapse namespace imports 2019-01-31 21:52:06 +01:00
Franz Liedke
b678367498 Catch pipeline's own exception 2019-01-31 21:52:06 +01:00
Franz Liedke
9a415670a3 Simplify PrerequisiteInterface 
I went with a return type of Collection, because it is easier to call
methods such as isEmpty() directly on those objects.
 2019-01-31 21:52:05 +01:00
Franz Liedke
3314a84b4e Fix the test setup and installer tests 
We are still testing the installation logic, but not testing the
actual CLI task. I would love to do that, but IMO we first need to
find a way to do this fully from the outside, by invoking and
talking to the installer through the shell.

Because acceptance tests are easier to do when fully decoupled from
the application. (After all, they are intended to save us from
breaking things when changing code; and we cannot prove that when
we change the tests at the same time.)

It might be easier to start with acceptance tests for the web
installer, though.
 2019-01-31 21:52:05 +01:00
Franz Liedke
f8430cda16 Split up the installer logic 
This is probably the most complicated way I could find to fix #1587.

Jokes aside, this was done with a few goals in mind:
- Reduce coupling between the installer and the rest of Flarum's
  "Application", which we are building during installation.
- Move the installer logic to several smaller classes, which can then
  be used by the web frontend and the console task, instead of the
  former hacking its way into the latter to be "DRY".
- Separate installer infrastructure (the "pipeline", with the ability
  to revert steps upon failure) from the actual steps being taken.

The problem was conceptual, and would certainly re-occur in a similar
fashion if we wouldn't tackle it at its roots.

It is fixed now, because we no longer use the ExtensionManager for
enabling extensions, but instead duplicate some of its logic. That is
fine because we don't want to do everything it does, e.g. omit
extenders' lifecycle hooks (which depend on the Application instance
being complete).

> for each desired change, make the change easy (warning: this may be
> hard), then make the easy change

- Kent Beck, https://twitter.com/kentbeck/status/250733358307500032

Fixes #1587.
 2019-01-31 21:52:04 +01:00
flarum-bot
f93f169943 Bundled output for commit 2dced2e6c8 [skip ci] 2019-01-25 04:46:37 +00:00
Daniël Klabbers
2dced2e6c8 Fixes #1686 
- further cleaned up the toggle action
- there's no way to remove the redraws because then the jquery isn't being fired properly
 2019-01-25 05:37:45 +01:00
Toby Zerner
2d714a06b5 Make the Request available to the Formatter\Rendering event (#1721) 
This is important because extensions may wish to render post content
differently depending on Request factors such as the actor. For example,
an attachments extension might wish to hide attachments from guests.

This solution is a bit of a hack-job for now, but soon when we refactor
the API layer to use tobscure/json-api-server, and also refactor the
Formatter layer, it can be revised.
 2019-01-22 23:33:49 +01:00
Daniël Klabbers
ca02e2adf4 Merge branch 'master' of github.com:flarum/core 2019-01-16 11:59:04 +01:00
Daniël Klabbers
a5363e084d update symfony/console, because illuminate/console needs a higher version 2019-01-16 11:58:42 +01:00
flarum-bot
dc92dea235 Bundled output for commit a39782368e [skip ci] 2019-01-16 09:05:46 +00:00
Daniël Klabbers
a39782368e fixes #1686, unable to edit user password 2019-01-16 09:58:22 +01:00
Daniël Klabbers
e17d4d57b7 revert the fix index names logic, preparing for illuminate 5.7 2019-01-15 21:03:32 +01:00
Daniël Klabbers
b20d590289 revert the fix index names logic, preparing for illuminate 5.7 2019-01-15 21:03:12 +01:00
Daniël Klabbers
bb6ed4a764 revert the fix index names logic, preparing for illuminate 5.7 2019-01-15 21:01:44 +01:00
Daniël Klabbers
c18731953d revert the fix index names logic, preparing for illuminate 5.7 2019-01-15 21:00:38 +01:00
Daniël Klabbers
1c7789683b set prefixing indices to be done automatically, now that illuminate can take care of that 2019-01-15 20:49:33 +01:00
Daniël Klabbers
b5bc2b2e87 further revert #41688c7 2019-01-15 20:49:06 +01:00
Daniël Klabbers
d56ea1ef07 reverts #41688c7 2019-01-15 20:39:38 +01:00
Daniël Klabbers
f0d626aaa7 Increasing test coverage (#1711) 
* added a few more tests, renamed singular to plural to match controller

* increase error reporting

* removed debugging and wait for tests
 2019-01-01 21:02:18 +01:00
Franz Liedke
7e0ec84028 Mail: Add an array of supported drivers 
This can be used for e.g. validation, or a dropdown in the frontend.
It can also be extended by extensions, such as flagrow/mail-drivers.

Refs #1169.
 2018-12-20 13:36:08 +01:00
Franz Liedke
77247d4378 Apply fixes from StyleCI (#1714) 
[ci skip] [skip ci]
 2018-12-20 13:13:58 +01:00
Franz Liedke
3fb0072b64 Register service providers alphabetically 
Order should not matter - and this is the only one that can
realistically stay consistent.
 2018-12-20 13:13:04 +01:00
Franz Liedke
9d3f2b1c49 Use a custom service provider for email configuration 2018-12-20 13:10:30 +01:00
Daniël Klabbers
8e37c2b8d8 updated constraint for 5.7 (#1698) 2018-12-20 08:20:52 +10:30
Franz Liedke
9989e76750 Don't resolve services when binding listeners 
Refs #1578.
 2018-12-19 22:47:58 +01:00
Franz Liedke
a26985cb0d Apply fixes from StyleCI (#1713) 
[ci skip] [skip ci]
 2018-12-19 22:42:54 +01:00
Franz Liedke
fadf87470d Avoid unnecessary event subscribers 
Refs #1578.
 2018-12-19 22:27:32 +01:00
Franz Liedke
c0a51b340b Fix UpdateServiceProvider 
- Shorten registration of routes
- Do not resolve view factory before booting
 2018-12-19 22:17:44 +01:00
Franz Liedke
428b2f07e8 Locale: Don't resolve manager just to configure it 
Refs #1578.
 2018-12-19 22:07:31 +01:00
Franz Liedke
4cd503746f Shorten registration of routes 2018-12-19 21:57:59 +01:00
Franz Liedke
c923d23f32 Frontends: Populate default routes only when they are resolved 2018-12-19 21:55:58 +01:00
Franz Liedke
6d1349e861 Make site extenders run after extensions 
Fixes #1708.
 2018-12-19 21:30:29 +01:00
Daniël Klabbers
3604dde442 add 7.3 to travis (#1710) 2018-12-19 18:09:36 +01:00
Daniel Klabbers
80c6efa1e8 fixes #1695, post comment count is incorrectly calculated based on all posts, including events 2018-12-19 15:07:32 +01:00
Daniel Klabbers
f1c672e12d fixes a notice due to the forum variable not being defined before compacting 2018-12-19 11:40:48 +01:00
Franz Liedke
b461281e09 Run local extenders before booting service providers 
We still need to discuss the priority of local extenders vs. those
from enabled extensions, but let's first fix the actual bug.

Refs #1708.
 2018-12-18 11:16:57 +01:00
Franz Liedke
9f3770eedb API: Populate default routes only when they are resolved 
Refs #1708.
 2018-12-18 10:33:01 +01:00
Franz Liedke
97d118939b Get rid of event subscribers that resolve services too early 
Refs flarum/core#1578.
 2018-12-18 00:18:48 +01:00
Franz Liedke
b47c791e39 Get rid of event subscribers that resolve services too early 
Refs flarum/core#1578.
 2018-12-18 00:11:36 +01:00
Franz Liedke
70a66a9529 Get rid of event subscribers that resolve services too early 
Refs flarum/core#1578.
 2018-12-16 16:24:05 +01:00
Franz Liedke
d4783f4ac5 Get rid of event subscribers that resolve services too early, part 1 
Refs flarum/core#1578.
 2018-12-16 15:14:00 +01:00
Franz Liedke
de1ff99356 Get rid of event subscribers that resolve services too early 
Refs flarum/core#1578.
 2018-12-16 15:06:10 +01:00
Franz Liedke
dfadc8f5fc Get rid of event subscribers that resolve services too early 
Refs flarum/core#1578.
 2018-12-16 15:00:02 +01:00
Franz Liedke
42b86cd3c1 Get rid of event subscribers that resolve services too early, part 1 
Refs flarum/core#1578.
 2018-12-15 17:26:25 +01:00
Franz Liedke
c22c74553f Get rid of event subscribers that resolve services too early 
Refs flarum/core#1578.
 2018-12-15 17:09:44 +01:00
Franz Liedke
c0f08ff907 Get rid of event subscribers that resolve services too early 
Refs flarum/core#1578.
 2018-12-15 16:58:00 +01:00
Franz Liedke
8aab6111ec Get rid of event subscribers that resolve services too early 
Refs flarum/core#1578.
 2018-12-15 16:47:41 +01:00
Franz Liedke
7dc7225b22 Remove unused import 2018-12-15 16:37:54 +01:00
Franz Liedke
c2cabd7c2e I can do this! 2018-12-15 16:24:31 +01:00