1
0
mirror of https://github.com/flarum/core.git synced 2025-08-14 20:34:10 +02:00
Commit Graph

9 Commits

Author SHA1 Message Date
Sami Mazouz
0a3f449f9e fix: post mentions with deleted author not rendering (#3432) 2022-06-02 13:38:24 +01:00
SychO9
cc62044e6f Support smart quotes in mentions format 2021-05-24 21:49:31 +01:00
Sami Mazouz
e407c66784 New mentions format, decouple usernames from mentions (#65)
* Convert user mentions to new `@"Display Name"#ID` format

* Handle deleted user's mentions

* Convert post mentions to `@"Display Name"#pID` format

* Handle deleted user's post mentions and deleted posts mentions

* Clean display name of `"#{letters}{numbers}` (replace with underscore _)

* Adapt integration tests to new mention formats

* Use a deleted attribute for user mentions

* Introduce cleanDisplayName util

* Detect new format with autocomplete

* Slug needed on rendering only

* Invalidate user mention tag when ID is invalid
This used to be implicitly done, when there was a username attribute configured, formatter would check that all attributes are available and if not invalidate.

since we now only have `displayname` and `id` attributes which are both available from the regex matching, formatter doesn't implicitly invalidate anymore and therefore validates ANY matches. So we explicitly invalidate the tag when the ID does not match a user.

* Allow username mention format with a setting

* Add tests for turning setting on/off

* Move setting check to tag filter
Because the configurator caches, changing the setting only takes effect after the cache is cleared.

* fix: showing autocomplete at the right moment

* Add dockblocks to explain unparsing process
2021-04-21 10:58:54 +01:00
Robert Turner
9c674f0a8b Fix mentioning a deleted user's post (#41)
Fixes #1956 - ErrorException: Trying to get property 'display_name' of 
non-object. ConfigureMentions::addPostId method set mention details 
based on if there was an existing post. This caused an error if there 
was an existing post, but the user who posted had been deleted. The 
mention details are now only set if there is a user associated with the 
post being mentioned.
2020-03-06 23:04:24 +01:00
Franz Liedke
3390bd5b02 Apply fixes from StyleCI 2019-11-29 23:02:17 +00:00
Shivanshu Patel
7afdbb1ea9 Remove like with and compare with equals (#37)
`_` is special character in mysql so like query was fetching different result for user who's unsername starts with or contains `_`
2019-08-16 15:57:35 +02:00
Franz Liedke
c2cabd7c2e I can do this! 2018-12-15 16:24:31 +01:00
Franz Liedke
99adb8e998 Fix copy-paste mistake 2018-12-15 16:01:03 +01:00
Franz Liedke
3656072ff4 Use Formatter extender to avoid resolving the UrlGenerator too early
Refs flarum/core#1578.
Fixes flarum/core#1703.
2018-12-15 12:06:58 +01:00