2 Commits

Author	SHA1	Message	Date
David Wheatley	7db2d0f697	chore: rewrite ModalManager and state to Typescript (#3007) ... * Rewrite ModalManagerState into Typescript - Fixes `attrs` parameter being marked as required - Add `isModalOpen` method * Rewrite ModalManager into Typescript * Fix incorrect type * Continue modal rewrite * Update attr typings * Fix correctly cast `this.constructor` calls * Cast to bool * Don't extend ModalAttrs by Record * Prevent missing abstract methods in child Modals from bricking frontend * Add missing `app` import * Address review comment Co-authored-by: David Sevilla Martin <6401250+datitisev@users.noreply.github.com> Co-authored-by: David Sevilla Martin <6401250+datitisev@users.noreply.github.com>	2021-10-31 00:29:10 +02:00
David Wheatley	3cf19dd2ea	Rewrite Button to Typescript (#2984) ... * Rename Button file * Convert to TS * Add debug warning helper Fires `console.warn`, but only when the forum is in debug mode. Can help to inform extension developers of possible issues with their JS code. * Simplify button content template * Rewrite Button component - Prefer `aria-label` over `title` - Don't duplicate button content to `title` attribute - Warn in debug mode if button has no accessible content - Use modern JS/TS syntax (`||=`, spread, etc) * Update to work with new Button component * Update warning Co-authored-by: Matt Kilgore <tankerkiller125@gmail.com> * Fire warning in `oncreate` * Format * Make Button have extensible Attributes type via generics * Update args type * Update js/src/common/components/Button.tsx Co-authored-by: Matt Kilgore <tankerkiller125@gmail.com> Co-authored-by: David Sevilla Martin <me@datitisev.me> Co-authored-by: Alexander Skvortsov <sasha.skvortsov109@gmail.com>	2021-08-22 20:38:01 +01:00