Franz Liedke
7e3eaa8c6a
Update changelog for beta.10
2019-09-15 22:43:36 +02:00
Franz Liedke
b270f80df8
Update changelog for beta.10
2019-09-15 22:43:23 +02:00
Franz Liedke
cbe7d4dfdb
Restore beta.9 behavior of assertCan()
...
In flarum/core#1854 , I changed the implementation of `assertCan()` to be
more aware of the user's log-in status. I came across this when unifying
our API's response status code when actors are not authenticated or not
authorized to do something.
@luceos rightfully had to tweak this again in 8e3eb59
, because the
behavior changed for one of the few API endpoints that checked for a
permission that even guests can have.
It turns out having this complex behavior in `assertCan()` is quite
misleading, because the name suggests a simple permission check and
nothing more.
Where we actually want to differ between HTTP 401 and 403, we can do
this using two method calls, and enforce it with our tests.
If this turns out to be problematic or extremely common, we can revisit
this and introduce a method with a different, better name in the future.
This commit restores the method's behavior in the last release, so we
also avoid another breaking change for extensions.
2019-09-14 21:32:00 +02:00
Franz Liedke
26d2031aa4
Add a test for viewUserList guest permission
...
This test would have failed without commit 8e3eb59
. Next, I will revert
that commit and most of my PR #1854 , so we need this test to ensure the
API continues to behave as desired.
2019-09-14 21:30:09 +02:00
Franz Liedke
f4219b0de6
Apply fixes from StyleCI
...
[ci skip] [skip ci]
2019-09-14 18:57:28 +00:00
Franz Liedke
9120e556eb
Convert more controller tests to feature tests
2019-09-14 13:09:56 +02:00
Tolga ALTAS
eaa6ca68cc
image_tooltip for markdown ( #147 )
2019-09-13 18:02:47 +02:00
Franz Liedke
b44c71348c
Update vulnerable JS dependencies
2019-09-13 15:41:22 +02:00
Franz Liedke
9bdf2a3c8d
Update vulnerable JS dependencies
2019-09-13 15:40:27 +02:00
Franz Liedke
94574514e4
Update vulnerable JS dependencies
2019-09-13 15:39:40 +02:00
Franz Liedke
cca8ca9ad7
Update vulnerable JS dependencies
2019-09-13 15:38:59 +02:00
Franz Liedke
ab198e5898
Update vulnerable JS dependencies
2019-09-13 15:35:13 +02:00
Franz Liedke
090b8fbd63
Update vulnerable JS dependencies
2019-09-13 15:34:23 +02:00
Franz Liedke
d9fb5ab31b
Update vulnerable JS dependencies
2019-09-13 15:33:06 +02:00
Franz Liedke
f85f1a7e06
Update vulnerable JS dependencies
2019-09-13 15:28:40 +02:00
Franz Liedke
12c73c048d
Update vulnerable JS dependencies
2019-09-13 15:27:47 +02:00
Franz Liedke
cad6ab1e6e
Update vulnerable JS dependencies
2019-09-13 15:26:10 +02:00
Franz Liedke
eca288f525
Send a HTTP 401 for incorrect login credentials
...
This fixes a regression from #1843 and #1854 . Now, the frontend again
shows the proper "Incorrect login details" message instead of "You
do not have permission to do that".
2019-09-13 15:03:03 +02:00
Franz Liedke
b75e8284da
Convert another controller test to feature test
...
Decouple from implementation, test closer to HTTP...
2019-09-13 14:58:45 +02:00
flarum-bot
9f8aeb7927
Bundled output for commit 5e53145bab
[skip ci]
2019-09-12 22:36:12 +00:00
David Sevilla Martín
5e53145bab
Fix errors caused by deletion alert when deleting users ( #1883 )
...
Refs #1788
TypeError: t.showDeletionAlert is not a function
at onSuccess(./src/forum/utils/UserControls.js:104:12)
Also, don't override 'this' param with user object for editAction
2019-09-13 00:34:05 +02:00
Daniël Klabbers
4bfcf4e052
moved the artisan binary override and commented some of the bindings for queue
2019-09-12 09:11:12 +02:00
flarum-bot
c1e03b0436
Bundled output for commit 5530422210
[skip ci]
2019-09-11 22:16:20 +00:00
David Sevilla Martin
5530422210
Fixes an issue where deleting a nonexistent model would error instead of resolving gracefully
2019-09-11 18:14:37 -04:00
Daniël Klabbers
c4806e19b5
prevent constant to be duplicated during tests
2019-09-11 12:20:35 +02:00
Daniël Klabbers
55d7e86a38
Merge branch 'master' of github.com:flarum/core
2019-09-11 11:59:10 +02:00
Daniël Klabbers
8e3eb5986f
Fixes an issue where permission checks aren't made for guest users,
...
due to the gate being accessed after the check whether the user
is registered/signed in.
2019-09-11 11:58:27 +02:00
luceos
8b029f9cd4
Apply fixes from StyleCI
...
[ci skip] [skip ci]
2019-09-11 09:43:46 +00:00
Daniël Klabbers
58e1c6cd99
Fixes the queue listen command. We might need to rectify this implementation before stable.
2019-09-11 11:42:52 +02:00
David Sevilla Martín
ebf8345dba
Add view & frontend documents for tags & tag discussion list ( #64 )
...
Refs flarum/core#1820 .
Fixes flarum/core#1134 .
2019-09-10 20:34:07 +02:00
Daniël Klabbers
923eea1cd8
Fixes an issue where a different cache driver is used and Formatter
...
attempts to load the s9e Renderer from the wrong cache. It has
to be saved locally so that it can be properly loaded using
the spl auto register functionality.
2019-09-10 12:33:25 +02:00
flarum-bot
811116638a
Bundled output for commit db3a037c97
[skip ci]
2019-09-10 00:23:18 +00:00
David Sevilla Martin
db3a037c97
Add license code to index.js, and line to LICENSE
2019-09-09 20:21:58 -04:00
flarum-bot
1091117e0f
Bundled output for commit b04b82b3a5
[skip ci]
2019-09-10 00:07:51 +00:00
David Sevilla Martin
b04b82b3a5
Add copyright notice for markdown toolbar code taken from GitHub
...
Refs #8
2019-09-09 20:06:18 -04:00
Franz Liedke
d4ad62c9b0
Fix instructions in PR template
2019-09-10 00:18:04 +02:00
flarum-bot
361d2e5ec2
Bundled output for commit 80ff7eb4ea
[skip ci]
2019-09-09 21:37:54 +00:00
David Sevilla Martín
2329d8050a
Add mark as read notification tooltip ( #146 )
2019-09-09 23:36:39 +02:00
David Sevilla Martín
80ff7eb4ea
Mark notification as read without visiting discussion ( #1874 )
2019-09-09 23:36:06 +02:00
flarum-bot
10bd406e18
Bundled output for commit 827c8ff50f
[skip ci]
2019-09-09 21:07:00 +00:00
David Sevilla Martín
827c8ff50f
Fix error thrown if textarea doesn't exist in TextEditor ( #1852 )
...
* Prevent textarea not existing from causing errors to be thrown
* Replace [0] with .length
2019-09-09 17:05:11 -04:00
flarum-bot
56d643c49d
Bundled output for commit 6cfa42eb90
[skip ci]
2019-09-09 20:20:21 +00:00
Daniël Klabbers
6cfa42eb90
Merge pull request #6 from flarum/ds/beta-8-fixes
...
Make embed functional again
2019-09-09 22:18:42 +02:00
Daniël Klabbers
22f3c82e9a
listen and restart currently fail in the queue, see #1879
2019-09-09 15:47:56 +02:00
flarum-bot
405cc7b56e
Bundled output for commit 12cc20ad62
[skip ci]
2019-09-08 17:33:39 +00:00
Matthew Kilgore
12cc20ad62
Fix the new edit user permission label ( #1870 )
2019-09-08 13:31:57 -04:00
David Sevilla Martín
5b8d8667d6
Add DB prefix to PHP tests ( #1855 )
...
* Add test job with PHP 7.3, MySQL & custom prefix
* Add prefix MariaDB test
* Add PHP 7.4 to tests
* Remove PHP 7.4 from tests
This reverts commit 270cba2f5f
.
2019-09-08 13:28:39 -04:00
flarum-bot
df8869a39f
Bundled output for commit 6ca55ec8ad
[skip ci]
2019-09-06 19:25:34 +00:00
Daniël Klabbers
6ca55ec8ad
Merge pull request #8 from flarum/ds/1702-fix-toolbar-in-ie-11
...
Use custom JSX implementation of GitHub's markdown toolbar that works in IE
2019-09-06 21:24:14 +02:00
David Sevilla Martín
fb45773ecb
Add back defaults for language and direction attributes ( #1860 )
2019-09-05 08:28:52 +02:00