b8b2941ca6
fix: Ensure user not false in post component
...
If no information about a relation exists, it will return false, not undefined. Therefore, the nullsafe operator is not enough to avoid issues here.
2022-01-08 18:26:51 -05:00
27294e8e0e
Format
2022-01-04 21:13:42 -05:00
2afe93a02c
Fix echo statements not showing up in debug modals or console trace
...
This was accidentially introduced in the recent Application permissions refactor, where `formattedError`was changed to always be a string array.
2022-01-04 21:13:15 -05:00
d8d85a9c14
fix: broken post/discussion soft delete ( #3249 )
...
* FIx broken post/discussion soft delete
Before the Model typescript rewrite, `pushAttributes` supported including relationship objects, which is hacky but incorrect behavior. With the rewrite, this functionality was broken.
This PR deprecates the functionality, adds a deprecated BC layer with a debug warning, and removes instances of incorrect usage.
* Update js/src/common/Model.ts
Co-authored-by: David Wheatley <hi@davwheat.dev >
* Update js/src/common/Model.ts
Co-authored-by: David Wheatley <hi@davwheat.dev >
* chore: format
Co-authored-by: David Wheatley <hi@davwheat.dev >
2022-01-04 13:26:46 +00:00
bf23f32a92
Apply flarum-cli audit fix ( #3248 )
2022-01-03 16:57:09 -05:00
9b9db24871
Bundled output for commit 32090c64bd
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-29 09:43:23 +00:00
32090c64bd
fix: prevent unwarranted a11y warnings on custom Button subclasses ( #3238 )
...
* fix: prevent unwarranted a11y warnings on UploadImageButton
* chore: format
* refactor
* fix: remove attr
2021-12-29 10:37:58 +01:00
a377e2c82b
Bundled output for commit 67b79f9d7d
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-28 20:13:43 +00:00
67b79f9d7d
fix(a11y): fix a11y warning in alert, and other a11y fixes ( #3237 )
...
* fix(a11y): fix a11y warning in alert, and other a11y fixes
* chore: correct import
* chore: use `class`
2021-12-28 21:08:34 +01:00
e13d515384
Bundled output for commit fb650a8696
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-28 19:56:55 +00:00
fb650a8696
fix: don't fire deprecation warnings for Mithril-originating action ( #3236 )
...
* fix: don't fire deprecation warnings for Mithril-originating actions
* Add comment
2021-12-28 20:51:13 +01:00
847441c23a
Bundled output for commit 4f61d2d7e1
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-28 19:40:54 +00:00
4f61d2d7e1
fix: mark render method in RouteResolver as optional ( #3235 )
2021-12-28 20:36:11 +01:00
cb6dfe269d
Bundled output for commit 9b011d742c
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-28 01:30:26 +00:00
9b011d742c
Merge pull request #3228 from flarum/as/v1.2_frontend_fixes
...
Some v1.2 frontend fixes
2021-12-27 20:24:53 -05:00
f6b1d65a57
Fix consecutive shows of same modal with different attrs
...
We need to specify a unique key for each modal so that the modals are fully destroyed and recreated. For instance, this fixes the signup modal being empty with OAuth register flows.
2021-12-27 18:28:11 -05:00
aa90edd2d7
Bundled output for commit afa36e71f8
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-27 23:18:49 +00:00
c939b4f274
Use translations for page titles in frontend
...
This gives more flexibility for customization, and allows overriding title structure via translations / linguist.
2021-12-27 18:15:12 -05:00
afa36e71f8
Only retain scroll position if coming from discussion ( #3229 )
...
Fixes https://discuss.flarum.org/d/29596-make-tag-hero-visible/8 .
If a user has just switched from one tag to another, they want to see the entire new discussion list, and information about which tag that discussion list corresponds to. There's no good reason to not display the hero header when switching tags.
2021-12-27 18:13:29 -05:00
7ababc95f3
Bundled output for commit 93e7732117
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-27 20:37:36 +00:00
93e7732117
fix: posts tab on users page broken
2021-12-27 21:32:04 +01:00
d53ab07648
Bundled output for commit de4e906a1a
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-27 19:59:19 +00:00
de4e906a1a
fix: returning null breaking CommentPosts
2021-12-27 20:54:00 +01:00
e7df8f121e
Bundled output for commit 5e3ad44a55
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-27 19:09:19 +00:00
5e3ad44a55
chore: maintenance pre-1.2 release ( #3213 )
...
* chore: bump js dependencies
* chore: bump Yarn to 3.1.1
* chore: re-patch TS binary
* chore: don't show diffs for yarn lockfile
2021-12-27 19:04:42 +00:00
7e54c70055
Bundled output for commit 998aff251f
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-27 19:02:33 +00:00
998aff251f
chore: 1.2 JS clean-up ( #3214 )
...
* fix: `extend.ts` TS error
* docs: fix incorrect JS docblocks
* chore: simplify some code
* chore: remove usages of prefixed JS function
* chore: consistent empty return types
* chore: format
* fix: typing errors
* chore: remove unneeded `@public` docblock modifiers
* Apply suggestions from code review
* Update js/src/forum/utils/slidable.js
Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com >
2021-12-27 18:58:18 +00:00
01e177eb52
Fix drawer focus trap making login form unclickable on mobile
...
Adding `clickOutsideDeactivates` seems to fix the issue, contrary to what the focus-trap documentation implies about it being unnecessary.
2021-12-26 22:45:58 -05:00
5e9f746f37
Fix Search error when user can't search
...
If there are no search sources, HTML for the Search component won't be rendered, so trying to attach listeners to it will likely error.
In this PR, we don't attach such listeners/logic if there are no sources. We also stop asserting that sources is defined to help avoid other similar issues in the future.
2021-12-26 20:04:48 -05:00
f63a40e313
Bundled output for commit 3dcf7bcd67
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-26 06:29:40 +00:00
3dcf7bcd67
fix: incorrect return type on pushPayload ( #3226 )
2021-12-26 01:25:16 -05:00
46d90487e8
Bundled output for commit 343f822771
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-22 18:58:42 +00:00
343f822771
fix: hide WelcomeHero when content is empty ( #3219 )
2021-12-22 13:54:21 -05:00
4ac6887c6f
Bundled output for commit e9de3f3c61
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-20 16:32:17 +00:00
e9de3f3c61
fix: breaking change in Search component - renaming of state property ( #3212 )
...
* fix: breaking change in search component's public api
* fix: add setter
* feat: add deprecation warning helper
This reduces bundle size as a result of deprecation warning in our JS, as well as maintaining a consistent format across warnings.
* feat: fire deprecation warning on usage of `Search.state`
* chore: use consistent deprecation warning across core
* fix: `/pull` not `/issue`
* chore: format
2021-12-20 16:28:28 +00:00
5ddfacf436
fix(postmeta): use app baseUrl instead of location.origin ( #3216 )
2021-12-20 16:25:04 +00:00
c8febb6199
Bundled output for commit 93e7b446bd
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-16 08:36:25 +00:00
93e7b446bd
fix: Add a11y labels to auth modal inputs ( #3207 )
2021-12-16 09:30:34 +01:00
6a90930373
Bundled output for commit eeff1e5b65
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-15 15:53:25 +00:00
eeff1e5b65
fix: replace throw with debug warning to fix breaking change ( #3206 )
...
* fix: replace throw with debug warning to fix breaking change
* Add link back to PR in warning
* fix: add missing `return null` for `!allowUnregistered` code path
* Clean up message -- move more info to PR comment
* Add setTimeout to delay call debug warning call until after `app.forum` is defined
* Add backticks around data type
2021-12-15 10:48:46 -05:00
1c2a33b253
Bundled output for commit 8fa7ffa175
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-14 22:16:16 +00:00
8fa7ffa175
feat: extract notification primaryControl items to an ItemList ( #3204 )
2021-12-14 22:11:48 +00:00
6a5afd1e4f
Bundled output for commit 56809ae20b
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-14 17:10:20 +00:00
56809ae20b
Merge pull request #2961 from the-turk/style-st
...
Improve selected text stylization
2021-12-14 12:06:22 -05:00
1efab83293
Bundled output for commit 3d754461b0
...
Includes transpiled JS/TS, and Typescript declaration files (typings).
[skip ci]
2021-12-14 03:11:57 +00:00
a82a160ecb
Format and Type Import Cleanup
...
Co-authored-by: David Wheatley <hi@davwheat.dev >
2021-12-13 22:04:36 -05:00
7b8eaf9045
Fix typing errors with app.modal.show
...
Unfortunately TypeScript doesn't support higher-kinded types, so we can't write this in a type-safe way.
2021-12-13 20:20:35 -05:00
850d555866
Slightly improve AlertManagerState show typing
...
`typeof Alert` is more correct than `Alert`, since we're accepting classes not instances.
2021-12-13 20:20:35 -05:00
7b8d507139
VnodeElementTag must be either a string or a class.
...
Unfortunately, TypeScript only supports strings and classes for JSX tags.
Therefore, our type definition should only allow for those two types.
see https://github.com/microsoft/TypeScript/issues/14789#issuecomment-412247771
2021-12-13 20:20:34 -05:00
959662f2e2
Format VnodeElementTag fix
2021-12-13 20:20:34 -05:00
